Fixed incorrect relative submodule URLs #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to git submodule documentation base path for relative submodule URL
is parent repository's root - not submodule "mount point".
So it's necessary to know "path" of parent repository to create correct submodule
URL.
Unfortunately, RefUrl function semantics are changed (kind of API change), so it can break something else that uses it.
At least it is required to change /templates/repo/view_list.tmpl in gogs project.
For more details see issue gogs/gogs#1926
Thus, maybe it's even better to make new function (temporary or permanently) similar to RefUrl (I don't know how bad it is to break compatibility in this particular case).