-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Scratch.Add with typed slice ([]int) to untyped slice ([]interface{}) fails #5275
Comments
bep
changed the title
Check .Scratch.Add vs slice
.Scratch.Add with typed slice ([]int) to untyped slice ([]interface{}) fails
Oct 8, 2018
Note: This has always been an issue, but it is the slice method that has gotten more "type aware" in Hugo 0.49. The example used in the forum isn't very common, though, but we should improve this. |
bep
added a commit
to bep/hugo
that referenced
this issue
Oct 8, 2018
bep
added a commit
to bep/hugo
that referenced
this issue
Oct 8, 2018
bep
added a commit
to bep/hugo
that referenced
this issue
Oct 8, 2018
bep
added a commit
to bep/hugo
that referenced
this issue
Oct 8, 2018
This commit consolidates the reflective collections handling in `.Scratch` vs the `tpl` package so they use the same code paths. This commit also adds support for a corner case where a typed slice is appended to a nil or empty `[]interface{}`. Fixes gohugoio#5275
bep
added a commit
that referenced
this issue
Oct 8, 2018
This commit consolidates the reflective collections handling in `.Scratch` vs the `tpl` package so they use the same code paths. This commit also adds support for a corner case where a typed slice is appended to a nil or empty `[]interface{}`. Fixes #5275
bep
added a commit
that referenced
this issue
Oct 10, 2018
This commit consolidates the reflective collections handling in `.Scratch` vs the `tpl` package so they use the same code paths. This commit also adds support for a corner case where a typed slice is appended to a nil or empty `[]interface{}`. Fixes #5275
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Related to #5269
See https://discourse.gohugo.io/t/updating-from-v0-48-to-v0-49-broke-build/14519/4?u=bep
Probably refactor the append logic in tpl and move that to a commons package and reuse.
The text was updated successfully, but these errors were encountered: