Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: run a Windows XP or Server 2003 builder #10267

Closed
bradfitz opened this issue Mar 27, 2015 · 21 comments

Comments

Projects
None yet
7 participants
@bradfitz
Copy link
Member

commented Mar 27, 2015

We should run a Windows Server 2003 builder. (not just WS2008/WS2012 on GCE)

In order of difficulty:

  1. if anybody has a spare one, that would be great to start.
  2. manually run one on AWS
  3. auto-create them on AWS as needed (include in trybots too). requires new builder infrastructure (cc @crawshaw)

AWS links:
http://aws.amazon.com/windows/products/ec2/server2003/ -- until July 14, 2015
http://aws.amazon.com/windows/products/ec2/server2003/access/ -- beyond July 14, 2015

/cc @alexbrainman @minux

@alexbrainman

This comment has been minimized.

Copy link
Member

commented Mar 27, 2015

@bradfitz I am not sure Windows Server 2003 support is important. It is effectively Windows XP. Not many people run that OS anymore (except myself). Microsoft discontinue its support soon.

Alex

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2015

We should have a builder for anything we pretend to halfway support.

If we don't support Go for Windows XP/2003, then why is #10162 still open? And the downloads page says Windows XP or above.

@alexbrainman

This comment has been minimized.

Copy link
Member

commented Mar 27, 2015

Fair enough.

@kardianos

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2015

@bradfitz I could host them for now. Want both a 386 and amd64 builder? I could also transfer you the ISOs and SKUs; I don't have a need for them aside from something like this now.

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2015

I think just amd64 or just 386 is fine. Whatever is easiest.

I'd prefer you just run one for now. Once I start to run one, I'd rather run it on AWS.

Email me at my golang.org address and I'll get you a builder key.

@minux

This comment has been minimized.

Copy link
Member

commented Mar 27, 2015

@alexbrainman

This comment has been minimized.

Copy link
Member

commented Mar 27, 2015

@minux I am not against more builders. I just don't think Windows Server 2003 is a good choice. We still don't have 386 builder (any). And even if you want something that is "very old", Windows XP 386 would me better choice. Windows XP 386 is much more common then Windows Server 2003 amd64. Just my 2c.

Alex

@minux

This comment has been minimized.

Copy link
Member

commented Mar 27, 2015

@kardianos

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2015

I ran XP 64-bit for a long time. My understanding is XP 64-bit based off
of 2003 64-bit. In my experience, the architecture matters much more the
the flavor in this case; sometimes the 64-bit version of XP/2003 is a
little "odd".

I think everyone is fine/wants a builder for amd64 and 386. I would suggest
the XP vs 2003 flavor won't matter for the builder's tests.
-Daniel

On Fri, Mar 27, 2015 at 3:09 PM Minux Ma notifications@github.com wrote:

If you see my replies to the windows 2012 builder thread, I'm actually
in favor of setting up a real 32-bit windows builder (i.e. windows xp).

I suggest that we need a 2003 builder because it's the lowest 64-bit
windows version that we claim to support and it's more common than
64-bit windows xp.


Reply to this email directly or view it on GitHub
#10267 (comment).

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Mar 28, 2015

WinXP 32-bit would be good too, of course.

@kardianos

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2015

I've started the builder. There are currently three failures at tip:
crypto/tls: Missing cert. Should I add from a different box or modify the
test? OS is up to date with MS provided patches.
runtime: The test failure is addressed in my posted CL, pending Alex's
investigation.
time: Several tests fail the accuracy tests; tickers and sleeps wake up too
soon from sleep. I'm honestly not sure if this is because I'm running it in
a VM or if Windows 2003 is just this loose with time (I mean I know its
loose, just a matter of degree).

-Daniel

On Sat, Mar 28, 2015 at 2:29 AM Brad Fitzpatrick notifications@github.com
wrote:

WinXP 32-bit would be good too, of course.


Reply to this email directly or view it on GitHub
#10267 (comment).

@kardianos

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2015

Also runtime/pprof sometimes fails. I haven't looked into that one.

On Sun, Mar 29, 2015 at 12:30 AM Daniel Theophanes kardianos@gmail.com
wrote:

I've started the builder. There are currently three failures at tip:
crypto/tls: Missing cert. Should I add from a different box or modify the
test? OS is up to date with MS provided patches.
runtime: The test failure is addressed in my posted CL, pending Alex's
investigation.
time: Several tests fail the accuracy tests; tickers and sleeps wake up
too soon from sleep. I'm honestly not sure if this is because I'm running
it in a VM or if Windows 2003 is just this loose with time (I mean I know
its loose, just a matter of degree).

-Daniel

On Sat, Mar 28, 2015 at 2:29 AM Brad Fitzpatrick notifications@github.com
wrote:

WinXP 32-bit would be good too, of course.


Reply to this email directly or view it on GitHub
#10267 (comment).

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Mar 29, 2015

We shouldn't install a cert from another box. We need to modify the code and/or test to work on a stock Windows system without modications.

As for missed ticks: first determine whether it's a VM thing. If it's just a VM thing, let's add an environment variable (IN_VM? like the IN_QEMU one we've used before) which, if enabled, skips such tests.

@bradfitz bradfitz added the os-windows label Mar 29, 2015

bradfitz added a commit to golang/build that referenced this issue Mar 31, 2015

cmd/coordinator: add BuildletPool abstraction; don't assume GCE
This starts the process of making the coordinator about to use the
buildlet on things other than GCE.

Update golang/go#8647 (ARM, reverse proxy or online.net)
Update golang/go#10267 (windows 2003 on AWS)
Update golang/go#9495 (OS X VMWare VMs on racked Mac Minis)

Change-Id: I5df79ea67e0ececba8b880e81bd93d4c80897455
Reviewed-on: https://go-review.googlesource.com/8198
Reviewed-by: David Crawshaw <crawshaw@golang.org>

@rsc rsc removed the os-windows label Apr 10, 2015

@rsc rsc added this to the Unplanned milestone Apr 10, 2015

@rsc rsc changed the title build: run a Windows Server 2003 builder x/build: run a Windows Server 2003 builder Apr 14, 2015

@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015

@rsc rsc added OS-Windows and removed builder labels Apr 14, 2015

@rsc rsc added the Builders label Jun 11, 2015

@bradfitz bradfitz self-assigned this Sep 7, 2016

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Sep 7, 2016

I have the start of a Windows XP SP3 builder now running on VMWare.

All tests passed with CGO_ENABLED=0 at tip just now. I haven't installed a C compiler yet.

Thanks again to @kardianos for the help.

@bradfitz bradfitz changed the title x/build: run a Windows Server 2003 builder x/build: run a Windows XP or Server 2003 builder Sep 23, 2016

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Feb 17, 2017

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Nov 6, 2017

I actually worked on the Windows XP builder during my leave a bit. I don't have it online yet, though.

@gopherbot

This comment has been minimized.

Copy link

commented Dec 9, 2017

Change https://golang.org/cl/83055 mentions this issue: dashboard, cmd/buildlet: add Windows XP builder

gopherbot pushed a commit to golang/build that referenced this issue Dec 9, 2017

dashboard, cmd/buildlet: add Windows XP builder
Updates golang/go#10267

Change-Id: I79064d9a2aca11bc14c73beef44d70098ed1ae3f
Reviewed-on: https://go-review.googlesource.com/83055
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Dec 9, 2017

The XP SP3 builder did a few commits, but failed with:

ok  	math/rand	1.441s
ok  	mime	0.146s
ok  	mime/multipart	0.925s
ok  	mime/quotedprintable	0.191s
--- FAIL: TestUDPConnSpecificMethods (0.02s)
	protoconn_test.go:142: write udp4 127.0.0.1:1138->127.0.0.1:1138: wsasendmsg: An invalid argument was supplied.
--- FAIL: TestWriteToUDP (0.00s)
	udpsock_test.go:168: write udp 127.0.0.1:1282: wsasendmsg: An invalid argument was supplied.
FAIL
FAIL	net	10.336s
2017/12/08 15:29:53 Failed: exit status 1

... including after I turned off the Windows firewall.

@alexbrainman, do you not also see that failure on your XP machine?

/cc @mikioh

@alexbrainman

This comment has been minimized.

Copy link
Member

commented Dec 9, 2017

@alexbrainman, do you not also see that failure on your XP machine?

I do see that failure on my Windows XP - I was meant to report / investigate this but I did not have time yet. This is new functionality that has been implemented in CL 76393 and related. The failure is because WSASendMsg returns WSAEINVAL, from https://msdn.microsoft.com/en-us/library/windows/desktop/ms741692(v=vs.85).aspx "The socket has not been bound with bind, or the socket was not created with the overlapped flag.". But on the bottom of that page it also says "Minimum supported client | Windows 8.1, ...". So I doubt this is designed to work on Windows XP. I propose we create an issue for it, and skip broken part of the test.

Alex

@gopherbot

This comment has been minimized.

Copy link

commented Dec 10, 2017

Change https://golang.org/cl/83115 mentions this issue: dashboard: don't snapshot XP builders (not shared anyway), and skip pprof tests

gopherbot pushed a commit to golang/build that referenced this issue Dec 10, 2017

dashboard: don't snapshot XP builders (not shared anyway), and skip p…
…prof tests

Updates golang/go#10267
Updates golang/go#22594

Change-Id: Ib6a9e13fbaaf4aad0b74008146b55e651658d4dd
Reviewed-on: https://go-review.googlesource.com/83115
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
@gopherbot

This comment has been minimized.

Copy link

commented Feb 20, 2018

Change https://golang.org/cl/95576 mentions this issue: dashboard: remove Windows XP builder

@golang golang locked and limited conversation to collaborators Feb 20, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.