Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
runtime: refactor into separate subpackages #11647
Now that the runtime is written in Go, it's worth taking the time to consider whether it could be better organized if it were split into packages. I think it could. Splitting the runtime into packages could also help improve the readability, in the style sense, of the code. That would make the runtime more accessible to new contributors.
It was also suggested by crawshaw that putting certain parts of the runtime into their own packages would make it easier to stub out or replace parts of the runtime. That would be helpful when bootstrapping a new architecture or os, where all of the runtime is not available, or in creating a modified runtime that would run without an os.
I'm in favor of splitting up the runtime, at least insofar as it is mostly just movement of existing code. This has the following advantages:
As per mdempsky's comment on golang.org/cl/14204, textflag.h is copied to the includes dir by cmd/dist, and the copy in runtime/internal/atomic is not actually being used. Updates #11647 Change-Id: Ie95c08903a9df54cea4c70ee9d5291176f7b5609 Reviewed-on: https://go-review.googlesource.com/16871 Run-TryBot: Michael Matloob <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-by: Matthew Dempsky <firstname.lastname@example.org>
The runtime package contains multitudes. I only care about a few of them. The signal to noise ratio on changes is currently too low. I hope that we will someday resume work on golang/go#11647, and/or implement some devapp filters. (Keyword-based? File-based?) Until then, I'm tapping out. Change-Id: Ib3baabb44f3a9ee48d78dcb8234c3752e0e42278 Reviewed-on: https://go-review.googlesource.com/c/build/+/171702 Reviewed-by: Josh Bleecher Snyder <email@example.com>