Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestDialerDualStack is flaky #12309

Closed
tzneal opened this issue Aug 25, 2015 · 3 comments

Comments

Projects
None yet
4 participants
@tzneal
Copy link
Member

commented Aug 25, 2015

It's been failing regularly on Windows/x64 , example at https://build.golang.org/log/6d9c92c981b5fb561f33eda94a418ee2ec05a846

--- FAIL: TestDialerDualStack (4.91s)
    dial_test.go:664: dial tcp 127.0.0.1:4306: i/o timeout

@mikioh mikioh added the OS-Windows label Aug 29, 2015

@mikioh

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2015

/CC @pmarks-net

Same as #12052, dialClosedPort on Windows also takes a bit long time?

@gopherbot

This comment has been minimized.

Copy link

commented Aug 31, 2015

CL https://golang.org/cl/14120 mentions this issue.

bradfitz added a commit that referenced this issue Aug 31, 2015

net: Increase the acceptable delay in TestDialerDualstack
This may fix the flakiness on Windows/x64, assuming that it's actually
due to a variance in the connection time which slightly exceeds 100ms.

150ms + 95ms = 245ms, which is still low enough to avoid triggering
Happy Eyeballs (300ms) on non-Windows platforms.

Updates #12309

Change-Id: I816a36fbc0a3e5c90e3cf1b75a134faf0d91557c
Reviewed-on: https://go-review.googlesource.com/14120
Run-TryBot: Paul Marks <pmarks@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@rsc

This comment has been minimized.

Copy link
Contributor

commented Oct 23, 2015

Fixed by CL 14120.

@rsc rsc added this to the Go1.6 milestone Oct 23, 2015

@rsc rsc closed this Oct 23, 2015

@golang golang locked and limited conversation to collaborators Oct 24, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.