Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: coordinator updates for coreos changes #12631

Closed
bradfitz opened this issue Sep 15, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@bradfitz
Copy link
Member

commented Sep 15, 2015

I updated to a new version of coreos on the farmer. (It had been ages)

I now notice that curl returns 23 or something if the file already exists, so sometimes the systemd unit fails to update unless I rm /opt/bin/coordinator first. Fix the systemd unit's shell line.

Also: I see problems bringing up the watcher now sometimes:

============== Watcher https://go.googlesource.com/go, last fail:
2015/09/15 21:17:27 Running watcher role.
2015/09/15 21:17:27 Watcher exiting after failure: listen tcp 127.0.0.1:21536: bind: address already in use


============== Watcher https://go.googlesource.com/go, current container logs:
time="2015-09-15T21:17:41Z" level=fatal msg="Error response from daemon: no such id: f01634497cc75822001481f0cfd0e6d1bd9fae92625c9b367c3492fa51d4291f" 

And sure enough, it's running, but not from an earlier process. We should verify that only our generation's watcher is running, and kill it otherwise.

/cc @adg

@bradfitz bradfitz added the Builders label Sep 15, 2015

@bradfitz bradfitz self-assigned this Sep 15, 2015

@ianlancetaylor ianlancetaylor added this to the Unreleased milestone Sep 15, 2015

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Sep 15, 2015

To @adg in chat:

23 Write error. Curl couldn't write data to a local filesystem or similar
but only started after coreos update
oh!
I know.
it's "Text file busy", now that the executable binary is now also used by the watcher process in the > > docker container
easy fix
gotta use install(1)
not curl -o

bradfitz added a commit to golang/build that referenced this issue Sep 15, 2015

cmd/coordinator/buildongce: don't curl -o directly to the coordinator…
… binary

It might still be running as the watcher. Use install(1) instead.

Updates golang/go#12631

Change-Id: I5c2b020b7c19ee0e912e345a03d21353b237fe61
Reviewed-on: https://go-review.googlesource.com/14586
Reviewed-by: Andrew Gerrand <adg@golang.org>
@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2015

Fixed by 4483ca5 and d79d77f945f5d

@bradfitz bradfitz closed this Sep 21, 2015

@golang golang locked and limited conversation to collaborators Sep 22, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.