Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upnet: more complete DNS stub resolver tests for uncommon scenarios #13295
Milestone
Comments
This comment has been minimized.
This comment has been minimized.
|
CL https://golang.org/cl/16953 mentions this issue. |
rsc
added a commit
that referenced
this issue
Dec 17, 2015
With certain names and search domain configurations the returned error would be one encountered while querying a generated name instead of the original name. This caused confusion when a manual check of the same name produced different results. Now prefer errors encountered for the original name. Also makes the low-level DNS connection plumbing swappable in tests enabling tighter control over responses without relying on the network. Fixes #12712 Updates #13295 Change-Id: I780d628a762006bb11899caf20b5f97b462a717f Reviewed-on: https://go-review.googlesource.com/16953 Reviewed-by: Russ Cox <rsc@golang.org>
This comment has been minimized.
This comment has been minimized.
|
Change https://golang.org/cl/102875 mentions this issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In working on #12778 I found there is not an easy way to test more uncommon DNS scenarios where tight control of responses and errors is needed.
For the pure Go stub resolver consider restructuring things to make this easier, such as with the ability to swap out real TCP/UDP connections for a stub so tight control is possible while still exercising the bulk of code.
@mdempsky mentioned considering possibly related restructuring for #13281.