Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/http2: TestChunkedResponseHeaders fails for http2 #13316

Closed
bradfitz opened this issue Nov 18, 2015 · 3 comments
Closed

x/net/http2: TestChunkedResponseHeaders fails for http2 #13316

bradfitz opened this issue Nov 18, 2015 · 3 comments
Assignees
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Nov 18, 2015

The new TestChunkedResponseHeaders_h2 test fails (TestChunkedResponseHeaders in HTTP/2 mode).

Fix.

@bradfitz bradfitz self-assigned this Nov 18, 2015
@bradfitz bradfitz added this to the Go1.6 milestone Nov 18, 2015
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 19, 2015

CL https://golang.org/cl/17046 mentions this issue.

bradfitz added a commit that referenced this issue Nov 19, 2015
This CL adds skipped failing tests, showing differences between HTTP/1
and HTTP/2 behavior. They'll be fixed in later commits.

Only a tiny fraction of the net/http tests have been split into their
"_h1" and "_h2" variants. That will also continue. (help welcome)

Updates #6891
Updates #13315
Updates #13316
Updates #13317

Change-Id: I16c3c381dbe267a3098fb266ab0d804c36473a64
Reviewed-on: https://go-review.googlesource.com/17046
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Andrew Gerrand <adg@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 25, 2015

CL https://golang.org/cl/17205 mentions this issue.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 25, 2015

CL https://golang.org/cl/17204 mentions this issue.

bradfitz added a commit that referenced this issue Nov 25, 2015
This compares the behavior of server handlers and the net/http
Transport in both HTTP/1 and HTTP/2 mode and verifies they're the
same.

This also moves some client<->server tests into clientserver_test.go.
Many of them were in serve_test.go or transport_test.go but were
basically testing both.

h2_bundle.go is an update of the golang.org/x/net/http2 code
from https://golang.org/cl/17204 (x/net git rev c745c36eab10)

Fixes #13315
Fixes #13316
Fixes #13317
Fixes other stuff found in the process too
Updates #6891 (http2 support in general)

Change-Id: Id9c45fad44cdf70ac95d2b89e578d66e882d3cc2
Reviewed-on: https://go-review.googlesource.com/17205
Reviewed-by: Andrew Gerrand <adg@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Nov 27, 2016
c3mb0 pushed a commit to c3mb0/net that referenced this issue Apr 2, 2018
Fixes found in the process of adding more A/B tests to net/http,
comparing HTTP/1 and HTTP/2 behaviors.

Most of the new tests are in Gerrit change Id9c45fad44cdf70ac9
in the "go" repo.

Fixes golang/go#13315
Fixes golang/go#13316
Fixes golang/go#13317
Fixes other stuff found in the process too
Updates golang/go#6891 (http2 support in general)

Change-Id: I83b5bfb471047312c0dcb0a0b21d709008f34136
Reviewed-on: https://go-review.googlesource.com/17204
Reviewed-by: Andrew Gerrand <adg@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.