-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto/tls: TLS handshake swallows errors #14539
Labels
Comments
CL https://golang.org/cl/19990 mentions this issue. |
gopherbot
pushed a commit
that referenced
this issue
Mar 2, 2016
This promotes a connection hang during TLS handshake to a proper error. This doesn't fully address #14539 because the error reported in that case is a write-on-socket-not-connected error, which implies that an earlier error during connection setup is not being checked, but it is an improvement over the current behaviour. Updates #14539. Change-Id: I0571a752d32d5303db48149ab448226868b19495 Reviewed-on: https://go-review.googlesource.com/19990 Reviewed-by: Adam Langley <agl@golang.org>
Fixed by https://golang.org/cl/19990. The rest of the issue is tracked in #14548. |
This was referenced Jul 30, 2016
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
go version
)?go version go1.6 darwin/amd64
go env
)?GOARCH="amd64"
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
Runnable example here: https://github.com/tamird/go-conn-repro
I expect that requests will either succeed or fail.
The test times out because a connection has hung in TLS handshake (both sides are trying to read). Stack trace:
This appears to be caused by errors not being propagated from the TLS handshake code.
The text was updated successfully, but these errors were encountered: