cmd/dist: should C warnings cause make.bash to fail?

[josharian]

The warning described in #14696 did not cause the build to fail. Should it have?

cc @bradfitz for opinions.

[bradfitz]

I'd be in favor of making C warnings fatal during make.bash.

@robpike, @rsc, @ianlancetaylor ... ?

[bradfitz]

Then again, C compilers add warnings all the time, and we were already bitten by that recently with a527bdb for #12345

[bradfitz]

Talking to myself, maybe we only make them fatal for dev builds, or only when run under the builders, so end users with release builds are never affected by the latest and greatest C warnings added in C compilers newer than what we used during development.

[josharian]

I like it.

[robpike]

SGTM

[alexbrainman]

SGTM

Alex

[bradfitz]

Gopherbot never mentioned this, probably because it says Do Not Review, but: https://go-review.googlesource.com/#/c/23005/