Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/tls: timeout tests #14722

Closed
randall77 opened this issue Mar 8, 2016 · 1 comment
Closed

crypto/tls: timeout tests #14722

randall77 opened this issue Mar 8, 2016 · 1 comment
Assignees
Milestone

Comments

@randall77
Copy link
Contributor

@randall77 randall77 commented Mar 8, 2016

Please answer these questions before submitting your issue. Thanks!

  1. What version of Go are you using (go version)?

tip

  1. What operating system and processor architecture are you using (go env)?

linux/amd64

  1. What did you do?

run the crypto/tls tests. Occasionally, I get the error:

--- FAIL: TestDialTimeout (0.01s)
tls_test.go:192: resulting error not a timeout: dial tcp 127.0.0.1:49575: i/o timeout

The test used to detect whether an error is a timeout is to look for the string "timed out" in the error string. Maybe we should include "timeout" also?

@bradfitz bradfitz self-assigned this Mar 8, 2016
@bradfitz bradfitz added this to the Go1.7 milestone Mar 8, 2016
@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Mar 8, 2016

I can't reproduce but I sent https://go-review.googlesource.com/20403 which at least also still passes for me and will fail with more info if it continues to flake for you.

@gopherbot gopherbot closed this in bf44c4c Mar 8, 2016
@golang golang locked and limited conversation to collaborators Mar 13, 2017
FiloSottile pushed a commit to FiloSottile/go that referenced this issue Oct 12, 2018
Don't do a substring search to test for a timeout error.

Fixes golang#14722 (maybe)

Change-Id: I4e18c749d6fd92c084a1b0b83a805119e1ae5ff2
Reviewed-on: https://go-review.googlesource.com/20403
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
FiloSottile pushed a commit to FiloSottile/go that referenced this issue Oct 12, 2018
Don't do a substring search to test for a timeout error.

Fixes golang#14722 (maybe)

Change-Id: I4e18c749d6fd92c084a1b0b83a805119e1ae5ff2
Reviewed-on: https://go-review.googlesource.com/20403
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.