Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: test fails when GOBIN is set #14901

Closed
crawshaw opened this issue Mar 21, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@crawshaw
Copy link
Contributor

commented Mar 21, 2016

$ export GOBIN=$HOME
$ go test net/http
--- FAIL: TestCmdGoNoHTTPServer (0.06s)
    http_test.go:79: go tool nm: exit status 1
FAIL
FAIL    net/http    0.104s
$

cc @bradfitz

@crawshaw crawshaw added this to the Go1.7 milestone Mar 21, 2016

@gopherbot

This comment has been minimized.

Copy link

commented Mar 21, 2016

CL https://golang.org/cl/20967 mentions this issue.

@gopherbot gopherbot closed this in d37d3bd Mar 22, 2016

@bradfitz

This comment has been minimized.

Copy link
Member

commented Mar 30, 2016

But now this broke me again for the opposite reason: The go binary in my $PATH is a script which uses the right go binary for the GOROOT I'm currently testing:

bradfitz@laptop http$ which go
/Users/bradfitz/bin/go
bradfitz@laptop http$ cat $HOME/bin/go
#!/bin/sh

exec $GOROOT/bin/go "$@"

@bradfitz bradfitz reopened this Mar 30, 2016

@bradfitz

This comment has been minimized.

Copy link
Member

commented Mar 30, 2016

And the error locally:

bradfitz@laptop http$ go test -v -run=TestCmdGoNoHTTPServer
=== RUN   TestCmdGoNoHTTPServer
--- FAIL: TestCmdGoNoHTTPServer (0.08s)
        http_test.go:71: go tool nm: exit status 1: open /Users/bradfitz/bin/go: unrecognized object file
FAIL
exit status 1
FAIL    net/http        0.126s
@gopherbot

This comment has been minimized.

Copy link

commented Mar 30, 2016

CL https://golang.org/cl/21292 mentions this issue.

@gopherbot gopherbot closed this in ca72f5f Mar 30, 2016

@golang golang locked and limited conversation to collaborators Mar 30, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.