Skip to content

x/net/http2: use Context #15134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bradfitz opened this issue Apr 5, 2016 · 4 comments
Closed

x/net/http2: use Context #15134

bradfitz opened this issue Apr 5, 2016 · 4 comments
Labels
FrozenDueToAge
Milestone
Go1.7

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Apr 5, 2016

Use Context in http2

cmd/bundle's lack of +build tag support might make it trickier.

(Parent bug: #14660)

/cc @adg
@bradfitz bradfitz self-assigned this Apr 5, 2016
@bradfitz bradfitz added this to the Go1.7 milestone Apr 5, 2016
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/23002 mentions this issue.

gopherbot pushed a commit to golang/net that referenced this issue May 10, 2016
@bradfitz
http2: make Transport use Request.Context, set Response.Uncompressed
96dbb96 
Go 1.7 introduces Request.Context and Response.Uncompressed. Use them
both in the http2 Transport when building for Go 1.7.

Tests are in the main repo.

Updates golang/go#15366
Updates golang/go#15134

Change-Id: I4b78a2710b6cf30c769c7f85cea15ecde653a317
Reviewed-on: https://go-review.googlesource.com/23002
Reviewed-by: Andrew Gerrand <adg@golang.org>
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/23003 mentions this issue.

gopherbot pushed a commit that referenced this issue May 10, 2016
@bradfitz
net/http: update bundled x/net/http2
f77f22b 
Updates x/net/http2 to git rev 96dbb961 for golang.org/cl/23002

Fixes #15366
Updates #15134 (server part remains)

Change-Id: I29336e624706f906b754da66381a620ae3293c6c
Reviewed-on: https://go-review.googlesource.com/23003
Reviewed-by: Andrew Gerrand <adg@golang.org>
Run-TryBot: Andrew Gerrand <adg@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/23221 mentions this issue.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/23220 mentions this issue.

gopherbot pushed a commit to golang/net that referenced this issue May 18, 2016
@bradfitz
http2: with Go 1.7 set Request.Context in ServeHTTP handlers
8aacbec 
And act the same as HTTP/1.x in Go 1.7.

Updates golang/go#15134

Change-Id: Ib64dd82cc5f8dd60e1680525f664d5b72be11fc6
Reviewed-on: https://go-review.googlesource.com/23220
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Gerrand <adg@golang.org>
@golang golang locked and limited conversation to collaborators May 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.7
Development

No branches or pull requests
2 participants
@bradfitz @gopherbot