Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: run sharded nacl builds #15242

Closed
bradfitz opened this issue Apr 11, 2016 · 3 comments
Closed

x/build: run sharded nacl builds #15242

bradfitz opened this issue Apr 11, 2016 · 3 comments
Assignees
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Apr 11, 2016

Shard the nacl builds.

@bradfitz bradfitz self-assigned this Apr 11, 2016
@bradfitz bradfitz added the Builders label Apr 11, 2016
@bradfitz bradfitz added this to the Unreleased milestone Apr 11, 2016
@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Apr 11, 2016

Notes:

diff --git a/src/nacltest.bash b/src/nacltest.bash
index 049aad2..869e749 100755
--- a/src/nacltest.bash
+++ b/src/nacltest.bash
@@ -77,6 +77,6 @@ GOROOT=$GOROOT_BOOTSTRAP $gobin/go run ../misc/nacl/mkzip.go -p syscall -r .. ..

 # Run standard build and tests.
 export PATH=$(pwd)/../misc/nacl:$PATH
-GOOS=nacl GOARCH=$naclGOARCH ./all.bash
+GOOS=nacl GOARCH=$naclGOARCH ./make.bash

-rm -f syscall/fstest_nacl.go
+#rm -f syscall/fstest_nacl.go

And then:

$ naclGOARCH=amd64p32 ./nacltest.bash

... to make. (this is where the coordinator should snapshot), then:

$ naclGOARCH=amd64p32 GOOS=nacl GOARCH=amd64p32 go tool dist test  --no-rebuild

... passes. So the coordinator's sharding should work fine once once nacltest.bash has a naclmake.bash mode or copy.

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 12, 2016

CL https://golang.org/cl/21851 mentions this issue.

gopherbot pushed a commit that referenced this issue Apr 12, 2016
Needed by the build system to shard tests. nacl was the last unsharded
builder.

(I considered also adding a -make-only flag to nacltest.bash, but that
wouldn't fail fast when the file didn't exist.)

Updates #15242

Change-Id: I6afc1c1fe4268ab98c0724b5764c67d3784caebe
Reviewed-on: https://go-review.googlesource.com/21851
Reviewed-by: Andrew Gerrand <adg@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented May 4, 2016

CL https://golang.org/cl/22780 mentions this issue.

@golang golang locked and limited conversation to collaborators May 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.