Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: plan9 is holding up trybots again #15251

Closed
bradfitz opened this issue Apr 12, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@bradfitz
Copy link
Member

commented Apr 12, 2016

plan9 has recently become slow again, holding up the trybots. (That is, 14 of the trybots will finish, but then plan9-386 continues to run for much longer....)

It seems like buildlets time out or otherwise disappear during tests, which causes the coordinator to retry the tests, thinking it was a transient network issue, and then the build system retries the whole build from the beginning in some cases (depending on which of the sharded helper buildlets disappears).

There is some plan9 bug here, but it's also a problem with the coordinator (maybe #13026)

I think I'll demote plan9 to be a regular builder again while I fix this and once we have logs with timings (#12669) showing that plan9 is behaving, then I'll reinstate it.

/cc @0intro @adg

@bradfitz bradfitz self-assigned this Apr 12, 2016

@bradfitz bradfitz added the Builders label Apr 12, 2016

@bradfitz bradfitz added this to the Unreleased milestone Apr 12, 2016

@bradfitz bradfitz changed the title build: plan9 is holding up trybots again x/build: plan9 is holding up trybots again Apr 12, 2016

gopherbot pushed a commit to golang/build that referenced this issue Apr 12, 2016

cmd/coordinator: remove plan9 as a trybot
Updates golang/go#15251

Change-Id: I723a70cdc6169252d2088dfcceea89ec5f8f9bc4
Reviewed-on: https://go-review.googlesource.com/21859
Reviewed-by: David Crawshaw <crawshaw@golang.org>
@adg

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2016

+1 for temporary demotion

@gopherbot

This comment has been minimized.

Copy link

commented Apr 17, 2016

CL https://golang.org/cl/22144 mentions this issue.

gopherbot pushed a commit that referenced this issue Apr 18, 2016

net: fix plan9 after context change, propagate contexts more
My previous https://golang.org/cl/22101 to add context throughout the
net package broke Plan 9, which isn't currently tested (#15251).

It also broke some old unsupported version of Windows (Windows 2000?)
which doesn't have the ConnectEx function, but that was only found
visually, since our minimum supported Windows version has ConnectEx.
This change simplifies the Windows and deletes the non-ConnectEx code
path.  Windows 2000 will work even less now, if it even worked
before. Windows XP remains our minimum supported version.

Specifically, the previous CL stopped using the "dial" function, which
0intro noted:
#15333 (comment)

This CL removes the dial function instead and makes plan9's net
implementation respect contexts, which likely fixes a number of
t.Skipped tests. I'm leaving that to 0intro to investigate.

In the process of propagating and respecting contexts for plan9, I had
to change some signatures to add contexts to more places and ended up
pushing contexts down into the Go-based DNS resolution as well,
replacing the pure-Go DNS implementation's use of "timeout
time.Duration" with a context instead.

Updates #11932
Updates #15328

Fixes #15333

Change-Id: I6ad1e62f38271cdd86b3f40921f2d0f23374936a
Reviewed-on: https://go-review.googlesource.com/22144
Reviewed-by: David du Colombier <0intro@gmail.com>
Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Sep 14, 2016

I'm going to keep this demoted. Closing.

@bradfitz bradfitz closed this Sep 14, 2016

@golang golang locked and limited conversation to collaborators Sep 14, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.