Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build: plan9 is holding up trybots again #15251
plan9 has recently become slow again, holding up the trybots. (That is, 14 of the trybots will finish, but then plan9-386 continues to run for much longer....)
It seems like buildlets time out or otherwise disappear during tests, which causes the coordinator to retry the tests, thinking it was a transient network issue, and then the build system retries the whole build from the beginning in some cases (depending on which of the sharded helper buildlets disappears).
There is some plan9 bug here, but it's also a problem with the coordinator (maybe #13026)
I think I'll demote plan9 to be a regular builder again while I fix this and once we have logs with timings (#12669) showing that plan9 is behaving, then I'll reinstate it.
My previous https://golang.org/cl/22101 to add context throughout the net package broke Plan 9, which isn't currently tested (#15251). It also broke some old unsupported version of Windows (Windows 2000?) which doesn't have the ConnectEx function, but that was only found visually, since our minimum supported Windows version has ConnectEx. This change simplifies the Windows and deletes the non-ConnectEx code path. Windows 2000 will work even less now, if it even worked before. Windows XP remains our minimum supported version. Specifically, the previous CL stopped using the "dial" function, which 0intro noted: #15333 (comment) This CL removes the dial function instead and makes plan9's net implementation respect contexts, which likely fixes a number of t.Skipped tests. I'm leaving that to 0intro to investigate. In the process of propagating and respecting contexts for plan9, I had to change some signatures to add contexts to more places and ended up pushing contexts down into the Go-based DNS resolution as well, replacing the pure-Go DNS implementation's use of "timeout time.Duration" with a context instead. Updates #11932 Updates #15328 Fixes #15333 Change-Id: I6ad1e62f38271cdd86b3f40921f2d0f23374936a Reviewed-on: https://go-review.googlesource.com/22144 Reviewed-by: David du Colombier <firstname.lastname@example.org> Reviewed-by: Mikio Hara <email@example.com> Reviewed-by: Ian Lance Taylor <firstname.lastname@example.org> Run-TryBot: Brad Fitzpatrick <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org>