New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: backport TimeoutHandler fix to Go 1.6.2 #15327

Closed
bradfitz opened this Issue Apr 15, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@bradfitz
Member

bradfitz commented Apr 15, 2016

As Andy Hochhaus writes on golang-nuts:

Starting in go 1.6.0 issue #14568 caused http.TimeoutHandler() to not behave correctly (timer was started too early and was not reset per http request). This bug was introduced in Dec 2015 in 0478f7b and resolved in Feb 2016 in bd68b8a.

Any chance the fix could be included in 1.6.2 as the bug was a 1.6 regression?

I agree we should backport the fix. I never realized it was introduced in 1.6.

@adg, @rsc?

@bradfitz bradfitz added this to the Go1.6.2 milestone Apr 15, 2016

@adg

This comment has been minimized.

Show comment
Hide comment
@adg

adg Apr 18, 2016

Contributor

Looks low-risk enough to be worthy of inclusion.

Contributor

adg commented Apr 18, 2016

Looks low-risk enough to be worthy of inclusion.

@adg

This comment has been minimized.

Show comment
Hide comment
@adg

adg Apr 19, 2016

Contributor

@bradfitz the cherry-pick of bd68b8a doesn't apply cleanly. Would you mind doing the cherry-pick, since you're the domain expert? Thank you.

Contributor

adg commented Apr 19, 2016

@bradfitz the cherry-pick of bd68b8a doesn't apply cleanly. Would you mind doing the cherry-pick, since you're the domain expert? Thank you.

@adg adg assigned bradfitz and unassigned adg Apr 19, 2016

@adg adg added the Release-OK label Apr 19, 2016

@bradfitz

This comment has been minimized.

Show comment
Hide comment
@bradfitz

bradfitz Apr 19, 2016

Member

Remind me of the process? (Or link to docs?)

Member

bradfitz commented Apr 19, 2016

Remind me of the process? (Or link to docs?)

@adg

This comment has been minimized.

Show comment
Hide comment
@adg

adg Apr 19, 2016

Contributor
# create work branch tracking release branch
$ git change release-branch.go1.6
$ git change go16pick
# cherry pick and mail cl
$ git cherry-pick $HASH
$ git mail
Contributor

adg commented Apr 19, 2016

# create work branch tracking release branch
$ git change release-branch.go1.6
$ git change go16pick
# cherry pick and mail cl
$ git cherry-pick $HASH
$ git mail

@adg adg removed Release-OK labels Apr 19, 2016

@adg adg closed this Apr 19, 2016

@golang golang locked and limited conversation to collaborators Apr 19, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.