Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: should pass -Wl,-z,relro when linking with -buildmode=pie #15485

Closed
mwhudson opened this issue Apr 29, 2016 · 3 comments
Closed

cmd/link: should pass -Wl,-z,relro when linking with -buildmode=pie #15485

mwhudson opened this issue Apr 29, 2016 · 3 comments
Labels
FrozenDueToAge

Comments

@mwhudson
Copy link
Contributor

@mwhudson mwhudson commented Apr 29, 2016

By my reading of the code, we currently do all the prep in the linker to work with -zrelro when linking with -buildmode=pie, but we don't actually pass it to the linker.

@crawshaw ?
@crawshaw

This comment has been minimized.

Sign in to view
Copy link
Contributor

@crawshaw crawshaw commented Apr 29, 2016

That's what it looks like. But then, how does anything work?
@ianlancetaylor

This comment has been minimized.

Sign in to view
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Apr 29, 2016

Many GNU/Linux distros pass -z relro by default.
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

@gopherbot gopherbot commented May 2, 2016

CL https://golang.org/cl/22687 mentions this issue.
@gopherbot gopherbot closed this in 45f39fb May 2, 2016
@golang golang locked and limited conversation to collaborators May 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@mwhudson @crawshaw @ianlancetaylor @gopherbot
You can’t perform that action at this time.