net/http: no way of manipulating timeouts in Handler

[FiloSottile]

A Handler has no way of changing the underlying connection Deadline, since it has no access to the net.Conn (except by maintaining a map from RemoteAddr to net.Conn via Server.ConnState, but it's more than anyone should need to do). Moreover, it can't implement a timeout itself because the Close method of the ResponseWriter implementation is not documented to unblock concurrent Writes.

This means that if the server has a WriteTimeout, the connection has a definite lifespan, and streaming is impossible. So servers with any streaming endpoints are forced not to implement timeouts at all on the entire Server.

A possible solution might be to expose the net.Conn in the Context. Another could be to allow interface upgrades to the SetDeadline methods on ResponseWriter. Yet another would be to make (*response).Close unblock (*response).Write.

[elithrar]

Given that we store the *http.Server in the request context, making net.Conn available in the context via (e.g.) ConnContextKey could be an option. This could be opt-in via a field on the http.Server as stuffing the request context with things by default is not ideal.

[elithrar]

Given that we store the *http.Server in the request context, making net.Conn available in the context via (e.g.) ConnContextKey could be an option. This could be opt-in via a field on the http.Server as stuffing the request context with things by default is not ideal.

[noblehng]

I think this can be done with providing a custom net.Listener to (*http.Server).Serve.

That is embedding a *net.TCPListener and overwriting the Accept method, which return a custom net.Conn. The custom net.Conn will embed a *net.TCPConn and overwrite the Write method.

The overwritten Write method could reset the write deadline on every write, or use a atomic counter to reset the write deadline on some numbers/bytes of consecutively write. But for truly on demand write deadline resetting, one still need some way to do that on the higer level handler side.

Since a http/2 connection can do multiplexing, it would be helpful to have a set of timeouts for individual stream. When a stream hang on client, we could use those timeouts to release resources associated with that stream, this is not possible with setting deadlines on the lower level underlying connection.

[noblehng]

I think this can be done with providing a custom net.Listener to (*http.Server).Serve.

That is embedding a *net.TCPListener and overwriting the Accept method, which return a custom net.Conn. The custom net.Conn will embed a *net.TCPConn and overwrite the Write method.

The overwritten Write method could reset the write deadline on every write, or use a atomic counter to reset the write deadline on some numbers/bytes of consecutively write. But for truly on demand write deadline resetting, one still need some way to do that on the higer level handler side.

Since a http/2 connection can do multiplexing, it would be helpful to have a set of timeouts for individual stream. When a stream hang on client, we could use those timeouts to release resources associated with that stream, this is not possible with setting deadlines on the lower level underlying connection.

[bradfitz]

@FiloSottile, we won't be exposing net.Conn to handlers, or let users explicitly set deadlines on conns. All public APIs need to consider both HTTP/1 and HTTP/2.

You propose many solutions, but I'd like to get a clear statement of the problem first. Even the title of this bug seems like a description of a lack of solution, rather than a problem that's not solvable.

I agree that the WriteTimeout is ill-specified. See also my comment about ReadTimeout here: #16958 (comment)

You allude to your original problem here:

So servers with any streaming endpoints are forced not to implement timeouts at all on the entire Server.

So you have an infinite stream, and you want to forcibly abort that stream if the user isn't reading fast enough? In HTTP/1, that means closing the TCP connection. In HTTP/2, that means sending a RST_STREAM.

I guess we need to define WriteTimeout before we make progress on this bug.

What do you think WriteTimeout should mean?

[bradfitz]

@FiloSottile, we won't be exposing net.Conn to handlers, or let users explicitly set deadlines on conns. All public APIs need to consider both HTTP/1 and HTTP/2.

You propose many solutions, but I'd like to get a clear statement of the problem first. Even the title of this bug seems like a description of a lack of solution, rather than a problem that's not solvable.

I agree that the WriteTimeout is ill-specified. See also my comment about ReadTimeout here: #16958 (comment)

You allude to your original problem here:

So servers with any streaming endpoints are forced not to implement timeouts at all on the entire Server.

So you have an infinite stream, and you want to forcibly abort that stream if the user isn't reading fast enough? In HTTP/1, that means closing the TCP connection. In HTTP/2, that means sending a RST_STREAM.

I guess we need to define WriteTimeout before we make progress on this bug.

What do you think WriteTimeout should mean?

[thincal]

Why not provide a timeout version of Read/Write ? Is there any reason ?

Request.Body.TimedRead(p []byte, timeout time.Duration)
Request.Body.TimedWrite(p []byte, timeout time.Duration)

My concrete case is:

case1 about read

client send data via. a POST API provided by server, but if the network disconnected during the server read request data via. request.Body.Read, the server will be blocked at Body.Read forever.

case2 about write

similar that it's server write data back to client.

So I need a timeout mechanism that server can be unblocked from this Read/Write.
This is very intuitive requirement, might be there are other solution already ?

Thanks.

[thincal]

Why not provide a timeout version of Read/Write ? Is there any reason ?

Request.Body.TimedRead(p []byte, timeout time.Duration)
Request.Body.TimedWrite(p []byte, timeout time.Duration)

My concrete case is:

case1 about read

client send data via. a POST API provided by server, but if the network disconnected during the server read request data via. request.Body.Read, the server will be blocked at Body.Read forever.

case2 about write

similar that it's server write data back to client.

So I need a timeout mechanism that server can be unblocked from this Read/Write.
This is very intuitive requirement, might be there are other solution already ?

Thanks.

[bradfitz]

What if the mechanism to abort blocked read or write I/O is to just exit from the ServeHTTP function?

So then handlers can do their own timers before reads/writes and cancel or extend them as necessary. That implies that all such reads & writes would need to be done in a separate goroutine. And then if they're too slow and the timer fires before the hander's I/O goroutine completes, just return from ServeHTTP and we'd either kill the TCP connection (for http1) or do a RST_STREAM (for http2).

I suppose then the problem is there's a small window where the I/O might've completed just in the window between the timer firing and the ServeHTTP code exiting, so then once the http package sees ServeHTTP is done, it may not see any calls still in Read or Write, and might then not fail the connection as intended.

That suggests we need some sort of explicit means of aborting a response. http1 has that with Hijacker.

I've recommended in the past that people just panic, since the http package has that weird feature where it recovers panics.

Would that work? Do all your I/O in separate goroutines, and panic if they take too long?

We might get data races with http1 and/or http2 with that, but I could probably make it work if you like the idea.

[bradfitz]

What if the mechanism to abort blocked read or write I/O is to just exit from the ServeHTTP function?

So then handlers can do their own timers before reads/writes and cancel or extend them as necessary. That implies that all such reads & writes would need to be done in a separate goroutine. And then if they're too slow and the timer fires before the hander's I/O goroutine completes, just return from ServeHTTP and we'd either kill the TCP connection (for http1) or do a RST_STREAM (for http2).

I suppose then the problem is there's a small window where the I/O might've completed just in the window between the timer firing and the ServeHTTP code exiting, so then once the http package sees ServeHTTP is done, it may not see any calls still in Read or Write, and might then not fail the connection as intended.

That suggests we need some sort of explicit means of aborting a response. http1 has that with Hijacker.

I've recommended in the past that people just panic, since the http package has that weird feature where it recovers panics.

Would that work? Do all your I/O in separate goroutines, and panic if they take too long?

We might get data races with http1 and/or http2 with that, but I could probably make it work if you like the idea.

[gopherbot]

CL https://golang.org/cl/32024 mentions this issue.

[gopherbot]

CL https://golang.org/cl/32024 mentions this issue.

[bradfitz]

Deferring to Go 1.9 due to lack of reply.

[bradfitz]

Deferring to Go 1.9 due to lack of reply.

[c4milo]

@bradfitz I faced a similar problem when I started with Go. I had a service in Node using HTTP 1.1 with chunked transfer encoding, it implemented bidirectional streaming over HTTP 1.1. On each write or read, the deadline/timeout would get reset in order for the connection to remain opened. It worked on Node.js which uses libuv. This predated websockets and avoided long polling. It is a little known technique but is somewhat mentioned in https://tools.ietf.org/rfc/rfc6202.txt (numeral 3). I also remember Twitter's streaming API using it. Anyway, migrating my Node service to Go was not possible because of the use of absolute timeouts/deadlines.

So, I guess @FiloSottile is referring to a similar case. At least in my particular scenario, what I wanted to do was to be able to reset the connection's write and read timeout/deadline so that the connection remained open but still got closed if it became idle.

[c4milo]

@bradfitz I faced a similar problem when I started with Go. I had a service in Node using HTTP 1.1 with chunked transfer encoding, it implemented bidirectional streaming over HTTP 1.1. On each write or read, the deadline/timeout would get reset in order for the connection to remain opened. It worked on Node.js which uses libuv. This predated websockets and avoided long polling. It is a little known technique but is somewhat mentioned in https://tools.ietf.org/rfc/rfc6202.txt (numeral 3). I also remember Twitter's streaming API using it. Anyway, migrating my Node service to Go was not possible because of the use of absolute timeouts/deadlines.

So, I guess @FiloSottile is referring to a similar case. At least in my particular scenario, what I wanted to do was to be able to reset the connection's write and read timeout/deadline so that the connection remained open but still got closed if it became idle.

[drakkan]

A timeout that restart on each write or read would be useful for my use case too and if implemented I could rewrite in go a legacy c++ application.

If the timeout could be set per request and not only globally would be a good plus

[drakkan]

A timeout that restart on each write or read would be useful for my use case too and if implemented I could rewrite in go a legacy c++ application.

If the timeout could be set per request and not only globally would be a good plus

[FiloSottile]

@bradfitz Sorry for not following up on this one, it turned out to be more nuanced than I thought (HTTP/2, brain, HTTP/2 exists) and didn't have the time to look at it further.

Doing I/O in a goroutine instead of the timer sounds upside-down, but I don't have specific points to make against it. What would make more sense to me would be a way to cancel the whole thing, which would make Body.Read/ResponseWriter.Write return an error that would then be handled normally.

Question, without such a mechanism, how is the user supposed to timeout a read when using ReadHeaderTimeout?

    // ReadHeaderTimeout is the amount of time allowed to read
    // request headers. The connection's read deadline is reset
    // after reading the headers and the Handler can decide what
    // is considered too slow for the body.

[FiloSottile]

@bradfitz Sorry for not following up on this one, it turned out to be more nuanced than I thought (HTTP/2, brain, HTTP/2 exists) and didn't have the time to look at it further.

Doing I/O in a goroutine instead of the timer sounds upside-down, but I don't have specific points to make against it. What would make more sense to me would be a way to cancel the whole thing, which would make Body.Read/ResponseWriter.Write return an error that would then be handled normally.

Question, without such a mechanism, how is the user supposed to timeout a read when using ReadHeaderTimeout?

    // ReadHeaderTimeout is the amount of time allowed to read
    // request headers. The connection's read deadline is reset
    // after reading the headers and the Handler can decide what
    // is considered too slow for the body.

[FiloSottile]

One possible solution would be for Request.Body to be documented to allow Close concurrent with Read, and not to panic on double Close, and for ResponseWriter to be upgradeable to io.Closer.

[FiloSottile]

One possible solution would be for Request.Body to be documented to allow Close concurrent with Read, and not to panic on double Close, and for ResponseWriter to be upgradeable to io.Closer.

[peter-mogensen]

For what it's worth ... I think we have a related use case. (only for reading requests and not for writing)

We have some slow clients doing large PUT requests - sometime on unstable connections which dies.
But we would like to allow these PUT requests as long as there is actually progress and Read() returns data. Preferably only on the endpoints where that should be allowed.

Currently, though we provide a net.Listener/net.Conn which sets Deadline on every Read/Write ... but that seems not a viable solution since it would interfere with timeouts set by net/http.Server.

[peter-mogensen]

For what it's worth ... I think we have a related use case. (only for reading requests and not for writing)

We have some slow clients doing large PUT requests - sometime on unstable connections which dies.
But we would like to allow these PUT requests as long as there is actually progress and Read() returns data. Preferably only on the endpoints where that should be allowed.

Currently, though we provide a net.Listener/net.Conn which sets Deadline on every Read/Write ... but that seems not a viable solution since it would interfere with timeouts set by net/http.Server.

[peter-mogensen]

Would that work? Do all your I/O in separate goroutines, and panic if they take too long?

The problem is defining what is "too long".
Often what you want is not to kill long running IO in absolute terms, but to kill "too slow" connections.
I don't want to kill a long running PUT request as long as it's actually transferring data. But I would kill a request only sending 1 byte/second.

These demands for IO activity should (for HTTP) only be enforced during ConnState stateActive (and stateNew). It would be OK for a connection to not have any IO activity in stateIdle.

I've been doing some experiments setting deadlines on connections - which is defeated by tls.Conn hiding the underlying connection object from external access.
Also trying to have a reaper go-routine Close connections with no IO activity. ... which becomes equally messy, although not impossible. (**)

Being able to set demands for IO activity during HTTP stateActive - or a more general way to do this for net.Conn without overwriting deadlines set by other API and regardless of whether the conn object is wrapped in TLS. - would be nice :)

** PS: ...much of the complexity comes from not being able to access the underlying connection in a crypto/tls.Conn object. I can understand why not exposing the connection to a Handler, but in the ConnState callback, is there any reason not to allow getting the underlying connection for a tls.Conn?

[peter-mogensen]

Would that work? Do all your I/O in separate goroutines, and panic if they take too long?

The problem is defining what is "too long".
Often what you want is not to kill long running IO in absolute terms, but to kill "too slow" connections.
I don't want to kill a long running PUT request as long as it's actually transferring data. But I would kill a request only sending 1 byte/second.

These demands for IO activity should (for HTTP) only be enforced during ConnState stateActive (and stateNew). It would be OK for a connection to not have any IO activity in stateIdle.

I've been doing some experiments setting deadlines on connections - which is defeated by tls.Conn hiding the underlying connection object from external access.
Also trying to have a reaper go-routine Close connections with no IO activity. ... which becomes equally messy, although not impossible. (**)

Being able to set demands for IO activity during HTTP stateActive - or a more general way to do this for net.Conn without overwriting deadlines set by other API and regardless of whether the conn object is wrapped in TLS. - would be nice :)

** PS: ...much of the complexity comes from not being able to access the underlying connection in a crypto/tls.Conn object. I can understand why not exposing the connection to a Handler, but in the ConnState callback, is there any reason not to allow getting the underlying connection for a tls.Conn?

[pwaller]

Just to throw in my 2¢, I also have personally hit the need to set timeouts on infinite connections, and have met someone at a go meetup who independently brought up the same problem.

In terms of API, why can't the underlying ResponseWriter implement Set{Read,Write}Deadline? It seems to me that they could happily do the write thing of sending STREAM_RST for http2. Just because it happens to implement the same API you'd use to timeout TCP connections doesn't mean it has to time out the TCP connection itself if there is another layer that can be used.

I agree with @FiloSottile's comment about the separate goroutine seeming upside-down. Though I sort of like it, it uses go's primitives in a clever non-obvious way which makes me feel nervous and seems like it would be hard to document.

[pwaller]

Just to throw in my 2¢, I also have personally hit the need to set timeouts on infinite connections, and have met someone at a go meetup who independently brought up the same problem.

In terms of API, why can't the underlying ResponseWriter implement Set{Read,Write}Deadline? It seems to me that they could happily do the write thing of sending STREAM_RST for http2. Just because it happens to implement the same API you'd use to timeout TCP connections doesn't mean it has to time out the TCP connection itself if there is another layer that can be used.

I agree with @FiloSottile's comment about the separate goroutine seeming upside-down. Though I sort of like it, it uses go's primitives in a clever non-obvious way which makes me feel nervous and seems like it would be hard to document.

[peter-mogensen]

Having ResponseWriter have Set*Deadline() would only solve to OP problem of writing data to the client. - not the problem of stopping long running PUT which don't really transfer data at any satisfying rate.

[peter-mogensen]

Having ResponseWriter have Set*Deadline() would only solve to OP problem of writing data to the client. - not the problem of stopping long running PUT which don't really transfer data at any satisfying rate.

[pwaller]

How about (*http.Request) or (*http.Request).Body implementing Set*Deadline?

[pwaller]

How about (*http.Request) or (*http.Request).Body implementing Set*Deadline?

[peter-mogensen]

If that can be implemented without interfering with other deadlines, like ReadTimeout, then it would be interesting to try.

[peter-mogensen]

If that can be implemented without interfering with other deadlines, like ReadTimeout, then it would be interesting to try.

[gaillard]

@bradfitz Is it expected with the current master of the http2 pkg that when panicing out of a handler and a left behind goroutine blocked on a body read or response writer write, for a panic to occur that is internal to the http2 pkg? (existing TimeoutHandler would have same issue). Or is the behavior your referring to what would be made safe if that is the chosen route, but doesn't exist today?

[gaillard]

@bradfitz Is it expected with the current master of the http2 pkg that when panicing out of a handler and a left behind goroutine blocked on a body read or response writer write, for a panic to occur that is internal to the http2 pkg? (existing TimeoutHandler would have same issue). Or is the behavior your referring to what would be made safe if that is the chosen route, but doesn't exist today?

[adg]

We ran into this issue on our project: upspin/upspin#313

We had our timeouts set quite low, as per @FiloSottile's recommendations but our users regularly send 1MB POST requests, which not all connections can deliver in a short time.

We would like to be able to set the timeout after reading the request headers. This would let us increase the timeouts for authenticated users only (we don't mind if our own users want to DoS us; at least we'll know who they are), but give unauthenticated users a very short timeout.

cc @robpike

[adg]

We ran into this issue on our project: upspin/upspin#313

We had our timeouts set quite low, as per @FiloSottile's recommendations but our users regularly send 1MB POST requests, which not all connections can deliver in a short time.

We would like to be able to set the timeout after reading the request headers. This would let us increase the timeouts for authenticated users only (we don't mind if our own users want to DoS us; at least we'll know who they are), but give unauthenticated users a very short timeout.

cc @robpike

[matope]

@bradfitz Hi, now that Go1.9 has been released, I'd like to proceed this issue.

For now, I've proposed 2 CLs and they're in review. One is for net/http and the other is for x/net/http2.

• https://golang.org/cl/47390
• https://golang.org/cl/47870

I think at least they worked as a POC to show that we're able to unblock pending I/Os on Body by using Clsoe(). But I'm not 100% sure if closing TCP connections by using Close() is a good design for HTTP/1.1 Bodies. (Would it cause unacceptable incompatibilities on its semantics?) I'd be happy if you could give me some feedbacks both on the design and on the implementations.

[matope]

@bradfitz Hi, now that Go1.9 has been released, I'd like to proceed this issue.

For now, I've proposed 2 CLs and they're in review. One is for net/http and the other is for x/net/http2.

• https://golang.org/cl/47390
• https://golang.org/cl/47870

I think at least they worked as a POC to show that we're able to unblock pending I/Os on Body by using Clsoe(). But I'm not 100% sure if closing TCP connections by using Close() is a good design for HTTP/1.1 Bodies. (Would it cause unacceptable incompatibilities on its semantics?) I'd be happy if you could give me some feedbacks both on the design and on the implementations.

[tombergan]

@matope I would like to have the context API explicitly rejected by the wider Go team before moving forward with the io.Closer approach. Otherwise we might some day end up with two APIs for the same problem, which will be ugly. I will try to write up a proposal this week.

Concurrently, perhaps we can short-circuit that conversation: Does anyone have a use case that cannot be solved with ReadContext / WriteContext, but can be solved by making net/http's ResponseWriter implement io.Closer?

[tombergan]

@matope I would like to have the context API explicitly rejected by the wider Go team before moving forward with the io.Closer approach. Otherwise we might some day end up with two APIs for the same problem, which will be ugly. I will try to write up a proposal this week.

Concurrently, perhaps we can short-circuit that conversation: Does anyone have a use case that cannot be solved with ReadContext / WriteContext, but can be solved by making net/http's ResponseWriter implement io.Closer?

[bradfitz]

I still don't like Close.

I'd rather see a function in the http package that returns a non-interface value (so we can add things to it later) given an *http.Request, with type name hopefully better than "HandlerHelper" or "HandlerWriter". (since ResponseWriter is taken already)

Then we could put methods for Flush (returning an error!) and Hijack and bytes written accessors and close and reset stream etc.

[bradfitz]

I still don't like Close.

I'd rather see a function in the http package that returns a non-interface value (so we can add things to it later) given an *http.Request, with type name hopefully better than "HandlerHelper" or "HandlerWriter". (since ResponseWriter is taken already)

Then we could put methods for Flush (returning an error!) and Hijack and bytes written accessors and close and reset stream etc.

[tombergan]

I understand not wanting to add yet-another-interface that users must cast ResponseWriter to, whether that interface is io.Closer, ctxio.Writer, or whatever. Adding a concrete struct that we can throw new methods on seems like a good idea. But it doesn't directly solve the problem raised by this bug.

How should callers apply per-Read/Write cancellations and deadlines: Should we add a Close or Cancel method as @matope proposed; should we add context methods as I proposed; or something else? i.e., I'd separate the questions:

1. What is the right API to solve this bug?
2. Should that API be exposed as an interface implemented by net/http's ResponseWriter, or as a new concrete struct that is somehow linked to an http.ResponseWriter?

AFAICT, we haven't settled the first question yet.

[tombergan]

I understand not wanting to add yet-another-interface that users must cast ResponseWriter to, whether that interface is io.Closer, ctxio.Writer, or whatever. Adding a concrete struct that we can throw new methods on seems like a good idea. But it doesn't directly solve the problem raised by this bug.

How should callers apply per-Read/Write cancellations and deadlines: Should we add a Close or Cancel method as @matope proposed; should we add context methods as I proposed; or something else? i.e., I'd separate the questions:

1. What is the right API to solve this bug?
2. Should that API be exposed as an interface implemented by net/http's ResponseWriter, or as a new concrete struct that is somehow linked to an http.ResponseWriter?

AFAICT, we haven't settled the first question yet.

[bradfitz]

I don't have time to read and consider the discussion above. I just wanted to say I'd heavily argue against new optional interfaces. I think the existing ones were probably a mistake and I'd like to stop the bleeding.

[bradfitz]

I don't have time to read and consider the discussion above. I just wanted to say I'd heavily argue against new optional interfaces. I think the existing ones were probably a mistake and I'd like to stop the bleeding.

[matope]

@bradfitz Thank you for your feedback!

I think introducing a new helper structure rather than adding new optional interfaces would be a good idea. It would enable us to extend the functionalities without breaking backward compatibility or having a lot of function-specific-interfaces.

I'm interested in your plan and I'd like to see more detail on it. But I'm not gonna rush you.
I'm gonna stop working on my CLs until new proposal will come.

Also, if the new struct supports settings of per-Read/Write timeout like below, users don't have to implement their own TimeoutReaders which I described above. I expect @tombergan would like this API).

func (r *Request) HandlerHelper()  *HandlerHelper {}

// HandlerHelper does some stuff on HTTP connection and stream.
// I don't come up with a nice name.
type HandlerHelper struct{
  // unexporeted fields and methods
}

 // Close closes the request connection(on HTTP/1.1) or reset the request stream (on HTTP/2).
func (hh *HanlderHelper) Close() error {}

// SetReadTimeout sets per-Read timeouts for Request (Body) if not 0
func (hh *HanlderHelper) SetReadTimeout(d time.Duration) {}

// SetWriteTimeout sets per-Write timeouts for Response (Body) if not 0
func (hh *HanlderHelper) SetWriteTimeout(d time.Duration) {}

[matope]

@bradfitz Thank you for your feedback!

I think introducing a new helper structure rather than adding new optional interfaces would be a good idea. It would enable us to extend the functionalities without breaking backward compatibility or having a lot of function-specific-interfaces.

I'm interested in your plan and I'd like to see more detail on it. But I'm not gonna rush you.
I'm gonna stop working on my CLs until new proposal will come.

Also, if the new struct supports settings of per-Read/Write timeout like below, users don't have to implement their own TimeoutReaders which I described above. I expect @tombergan would like this API).

func (r *Request) HandlerHelper()  *HandlerHelper {}

// HandlerHelper does some stuff on HTTP connection and stream.
// I don't come up with a nice name.
type HandlerHelper struct{
  // unexporeted fields and methods
}

 // Close closes the request connection(on HTTP/1.1) or reset the request stream (on HTTP/2).
func (hh *HanlderHelper) Close() error {}

// SetReadTimeout sets per-Read timeouts for Request (Body) if not 0
func (hh *HanlderHelper) SetReadTimeout(d time.Duration) {}

// SetWriteTimeout sets per-Write timeouts for Response (Body) if not 0
func (hh *HanlderHelper) SetWriteTimeout(d time.Duration) {}

[FiloSottile]

The current docs for Read[Header]Timeout say:

        // ReadTimeout is the maximum duration for reading the entire
        // request, including the body.
        //
        // Because ReadTimeout does not let Handlers make per-request
        // decisions on each request body's acceptable deadline or
        // upload rate, most users will prefer to use
        // ReadHeaderTimeout. It is valid to use them both.
        ReadTimeout time.Duration

        // ReadHeaderTimeout is the amount of time allowed to read
        // request headers. The connection's read deadline is reset
        // after reading the headers and the Handler can decide what
        // is considered too slow for the body.
        ReadHeaderTimeout time.Duration

Given this issue is not fixed yet, it sounds misleading to me. ReadHeaderTimeout does nothing against a malicious attacker, and "the Handler can decide what is considered too slow for the body" is inaccurate, not having a way to set deadlines.

Am I missing something?

[FiloSottile]

The current docs for Read[Header]Timeout say:

        // ReadTimeout is the maximum duration for reading the entire
        // request, including the body.
        //
        // Because ReadTimeout does not let Handlers make per-request
        // decisions on each request body's acceptable deadline or
        // upload rate, most users will prefer to use
        // ReadHeaderTimeout. It is valid to use them both.
        ReadTimeout time.Duration

        // ReadHeaderTimeout is the amount of time allowed to read
        // request headers. The connection's read deadline is reset
        // after reading the headers and the Handler can decide what
        // is considered too slow for the body.
        ReadHeaderTimeout time.Duration

Given this issue is not fixed yet, it sounds misleading to me. ReadHeaderTimeout does nothing against a malicious attacker, and "the Handler can decide what is considered too slow for the body" is inaccurate, not having a way to set deadlines.

Am I missing something?

[tv42]

That suggests we need some sort of explicit means of aborting a response.

This seems to be now implemented, as panic(http.ErrAbortHandler), I think.

[tv42]

That suggests we need some sort of explicit means of aborting a response.

This seems to be now implemented, as panic(http.ErrAbortHandler), I think.

[rsc]

Is http.ErrAbortHandler enough? Can we close this?

[rsc]

Is http.ErrAbortHandler enough? Can we close this?

[FiloSottile]

So if I understand correctly the plan is to set a timeout on the main goroutine with a panic at the end, and do your I/O in a new goroutine. https://play.golang.org/p/J8IDixEn9y1

I see a few issues with this:

1. It doesn't (currently) work. If you run the Play link above the I/O goroutine remains blocked on the slow reader after the handler panics. http.ResponseWriter.Write should unblock and return errors once ServeHTTP returns. This is arguably just a bug.
2. It's convoluted and hard to discover for something (timeouts) that we would want most Handlers to manage well. It feels like net/http internals spilled over.
3. It feels very easy to get wrong, losing track of a goroutine, or something like that.
4. It requires special behavior from the http.ResponseWriter provider (see 1) that was not in the interface before.

[FiloSottile]

So if I understand correctly the plan is to set a timeout on the main goroutine with a panic at the end, and do your I/O in a new goroutine. https://play.golang.org/p/J8IDixEn9y1

I see a few issues with this:

1. It doesn't (currently) work. If you run the Play link above the I/O goroutine remains blocked on the slow reader after the handler panics. http.ResponseWriter.Write should unblock and return errors once ServeHTTP returns. This is arguably just a bug.
2. It's convoluted and hard to discover for something (timeouts) that we would want most Handlers to manage well. It feels like net/http internals spilled over.
3. It feels very easy to get wrong, losing track of a goroutine, or something like that.
4. It requires special behavior from the http.ResponseWriter provider (see 1) that was not in the interface before.

[bradfitz]

@FiloSottile, as background, we're asking whether this is enough for now because there's no great place to put new options. We want to stop adding optional interfaces for http.ResponseWriter. They compose poorly.

If we make a "v2" version of net/http, we can fix this (and many other things), but we're wondering if we really need anything more for now.

If you feel strongly we do need this now, then what API do you propose?

[bradfitz]

@FiloSottile, as background, we're asking whether this is enough for now because there's no great place to put new options. We want to stop adding optional interfaces for http.ResponseWriter. They compose poorly.

If we make a "v2" version of net/http, we can fix this (and many other things), but we're wondering if we really need anything more for now.

If you feel strongly we do need this now, then what API do you propose?

[bradfitz]

I was about to propose a hypothetical API but I realized I wasn't sure whether I had the right bug so I just tried to reread this whole bug to find the problem statement and I'm mostly seeing solutions.

Can somebody summarize the problem we're trying to solve here?

[bradfitz]

I was about to propose a hypothetical API but I realized I wasn't sure whether I had the right bug so I just tried to reread this whole bug to find the problem statement and I'm mostly seeing solutions.

Can somebody summarize the problem we're trying to solve here?

[FiloSottile]

The shortest tl;dr is that there is no way to set timeouts based on the endpoint or on the client, but only server-wide, nor there is any way to update timeouts while serving a response based on the changing circumstances.

The reason one wants to set timeouts is to protect against clients going away or being intentionally slow. A reason one might want to exempt an endpoint is for example if that handler is serving streaming content or long downloads. A reason one might want to exempt a client is for example following authentication.

#16100 (comment) is a good practical example. I feel like the first two paragraphs of my original report are also not solution-oriented.

[FiloSottile]

The shortest tl;dr is that there is no way to set timeouts based on the endpoint or on the client, but only server-wide, nor there is any way to update timeouts while serving a response based on the changing circumstances.

The reason one wants to set timeouts is to protect against clients going away or being intentionally slow. A reason one might want to exempt an endpoint is for example if that handler is serving streaming content or long downloads. A reason one might want to exempt a client is for example following authentication.

#16100 (comment) is a good practical example. I feel like the first two paragraphs of my original report are also not solution-oriented.

[bradfitz]

Okay, thanks.

If the client goes away ("laptop lid closes in a coffee shop" case), our default TCP keep-alive detection will kill the connection after some time. So I'm less worried about that.

But having different policies based on authentication is a good example.

I imagine this would be equally about read timeouts in addition to write timeouts.

How about something like this for an API: (ignoring the names)

package http // net/http

func NewHandlerController(w http.ResponseWriter, r *http.Request) *HandlerController { ... }

type HandlerController struct { /* opaque */ }

// SetFoo changes the foo deadline and reports whether it was successfully adjusted.
func (hc *HandlerController) SetFoo(time.Time) bool { ... }
func (hc *HandlerController) SetBar(time.Duration) bool { ... }

And then we're largely insulated from the mechanism we use to implement it over time. If we want to do private magic on the ResposneWriter interface, we can. If we want to do magic private context values, we can. But the user gets concrete types.

I'd start with that (for Go 1.12) and implement it for HTTP/1 and HTTP/2 only and not provide a way for others to implement it for their own Servers/ResponseWriters right away, knowing that this API would let us do so later.

I'm not really a fan of the name HandlerController name, though, but it's verbose here as an example.

[bradfitz]

Okay, thanks.

If the client goes away ("laptop lid closes in a coffee shop" case), our default TCP keep-alive detection will kill the connection after some time. So I'm less worried about that.

But having different policies based on authentication is a good example.

I imagine this would be equally about read timeouts in addition to write timeouts.

How about something like this for an API: (ignoring the names)

package http // net/http

func NewHandlerController(w http.ResponseWriter, r *http.Request) *HandlerController { ... }

type HandlerController struct { /* opaque */ }

// SetFoo changes the foo deadline and reports whether it was successfully adjusted.
func (hc *HandlerController) SetFoo(time.Time) bool { ... }
func (hc *HandlerController) SetBar(time.Duration) bool { ... }

And then we're largely insulated from the mechanism we use to implement it over time. If we want to do private magic on the ResposneWriter interface, we can. If we want to do magic private context values, we can. But the user gets concrete types.

I'd start with that (for Go 1.12) and implement it for HTTP/1 and HTTP/2 only and not provide a way for others to implement it for their own Servers/ResponseWriters right away, knowing that this API would let us do so later.

I'm not really a fan of the name HandlerController name, though, but it's verbose here as an example.

[FiloSottile]

LGTM, although I would return an error (Set[Read|Write]Deadline(time.Time) error) so that we can communicate why the feature is not available.

[FiloSottile]

LGTM, although I would return an error (Set[Read|Write]Deadline(time.Time) error) so that we can communicate why the feature is not available.

[edaniels]

Pulling together a few comments over time here. Given the ResponseWriter is what currently let's us hijack the underlying connection, would it be sufficient to start having net/http's ResponseWriterimplementio.Closerand a newhttp.DeadlineController` with methods:

type DeadlineController interface {
  SetReadDeadline(time.Duration)
  SetWriteDeadline(time.Duration)
}

This would be in line with the other interfaces already in use and implemented by the underlying ResponseWriter from the server.

For a user wanting to implement Server-Side Events, they could do the following:

func streamHandler(w http.ResponseWriter, r *http.Request) {
	w.Header().Set("Content-Type", "text/event-stream")
	controller, ok := w.(http.DeadlineController)
	if !ok {
		panic("expected w to be a http.DeadlineController")
	}
	for  {
		controller.SetWriteDeadline(2*time.Second)
		w.Write([]byte("data: some piece of data that takes up to 2 seconds to write\n\n"))
		w.(http.Flusher).Flush()
		time.Sleep(time.Second)
	}
}

You could mix in io.Closer into that example or use the request.Context to signal the handler to stop the stream.

I do also like @tombergan's mention of contextified reads and writes as potentially new methods so as to avoid breaking the library.

With all that said, it feels like the right future approach is to keep functionality scoped to the ResponseWriter and not at a higher level (handler, router, or server) for the motivation of having the most flexibility and obvious/expected API.

[edaniels]

Pulling together a few comments over time here. Given the ResponseWriter is what currently let's us hijack the underlying connection, would it be sufficient to start having net/http's ResponseWriterimplementio.Closerand a newhttp.DeadlineController` with methods:

type DeadlineController interface {
  SetReadDeadline(time.Duration)
  SetWriteDeadline(time.Duration)
}

This would be in line with the other interfaces already in use and implemented by the underlying ResponseWriter from the server.

For a user wanting to implement Server-Side Events, they could do the following:

func streamHandler(w http.ResponseWriter, r *http.Request) {
	w.Header().Set("Content-Type", "text/event-stream")
	controller, ok := w.(http.DeadlineController)
	if !ok {
		panic("expected w to be a http.DeadlineController")
	}
	for  {
		controller.SetWriteDeadline(2*time.Second)
		w.Write([]byte("data: some piece of data that takes up to 2 seconds to write\n\n"))
		w.(http.Flusher).Flush()
		time.Sleep(time.Second)
	}
}

You could mix in io.Closer into that example or use the request.Context to signal the handler to stop the stream.

I do also like @tombergan's mention of contextified reads and writes as potentially new methods so as to avoid breaking the library.

With all that said, it feels like the right future approach is to keep functionality scoped to the ResponseWriter and not at a higher level (handler, router, or server) for the motivation of having the most flexibility and obvious/expected API.

[pd60193]

The shortest tl;dr is that there is no way to set timeouts based on the endpoint or on the client, but only server-wide, nor there is any way to update timeouts while serving a response based on the changing circumstances.

I want to do this. I have an endpoint which exports a large file while others perform operations on smaller sized data. I would like to keep different timeouts for these two different endpoints.

[pd60193]

The shortest tl;dr is that there is no way to set timeouts based on the endpoint or on the client, but only server-wide, nor there is any way to update timeouts while serving a response based on the changing circumstances.

I want to do this. I have an endpoint which exports a large file while others perform operations on smaller sized data. I would like to keep different timeouts for these two different endpoints.