cmd/go: drop runtime from plugins #17150

Open
rasky opened this Issue Sep 18, 2016 · 7 comments

Comments

Projects
None yet
7 participants
@rasky
Contributor

rasky commented Sep 18, 2016

It looks like plugins contain a copy of the runtime. I guess that copy is unused, and could probably be dropped, reducing binary size.

@rasky

This comment has been minimized.

Show comment
Hide comment
@rasky

rasky Sep 18, 2016

Contributor

/cc @crawshaw

Contributor

rasky commented Sep 18, 2016

/cc @crawshaw

@crawshaw

This comment has been minimized.

Show comment
Hide comment
@crawshaw

crawshaw Sep 18, 2016

Contributor

Yup, I had a TODO about this I lost somewhere in the CL patchsets.

It should be straightforward, it's already possible to build -linkshared binaries without a runtime. I expect most of the work is careful argument construction in cmd/go.

Contributor

crawshaw commented Sep 18, 2016

Yup, I had a TODO about this I lost somewhere in the CL patchsets.

It should be straightforward, it's already possible to build -linkshared binaries without a runtime. I expect most of the work is careful argument construction in cmd/go.

@crawshaw crawshaw changed the title from Drop runtime from plugins to cmd/go: drop runtime from plugins Sep 18, 2016

@quentinmit quentinmit added the NeedsFix label Oct 3, 2016

@quentinmit quentinmit added this to the Go1.8 milestone Oct 3, 2016

@rsc

This comment has been minimized.

Show comment
Hide comment
@rsc

rsc Oct 21, 2016

Contributor

@crawshaw, still want to do this for Go 1.8?

Contributor

rsc commented Oct 21, 2016

@crawshaw, still want to do this for Go 1.8?

@crawshaw

This comment has been minimized.

Show comment
Hide comment
@crawshaw

crawshaw Oct 21, 2016

Contributor

Pushing to 1.9, so I can spend what cycles I have on bugs.

Contributor

crawshaw commented Oct 21, 2016

Pushing to 1.9, so I can spend what cycles I have on bugs.

@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Sep 11, 2017

Change https://golang.org/cl/62352 mentions this issue: cmd/link: correct symbol table order for plugin-use code on darwin/amd64

Change https://golang.org/cl/62352 mentions this issue: cmd/link: correct symbol table order for plugin-use code on darwin/amd64

@crawshaw

This comment has been minimized.

Show comment
Hide comment
@crawshaw

crawshaw Sep 23, 2017

Contributor

@hirochachacha at one point you had a CL exploring removing the runtime from plugins. Are you still working on it?

Contributor

crawshaw commented Sep 23, 2017

@hirochachacha at one point you had a CL exploring removing the runtime from plugins. Are you still working on it?

@hirochachacha

This comment has been minimized.

Show comment
Hide comment
@hirochachacha

hirochachacha Sep 23, 2017

Contributor

@crawshaw No, I'm afraid not.

Contributor

hirochachacha commented Sep 23, 2017

@crawshaw No, I'm afraid not.

@rsc rsc modified the milestones: Go1.10, Unplanned Dec 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment