New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: drop runtime from plugins #17150

Open
rasky opened this Issue Sep 18, 2016 · 7 comments

Comments

Projects
None yet
7 participants
@rasky
Member

rasky commented Sep 18, 2016

It looks like plugins contain a copy of the runtime. I guess that copy is unused, and could probably be dropped, reducing binary size.

@rasky

This comment has been minimized.

Member

rasky commented Sep 18, 2016

/cc @crawshaw

@crawshaw

This comment has been minimized.

Contributor

crawshaw commented Sep 18, 2016

Yup, I had a TODO about this I lost somewhere in the CL patchsets.

It should be straightforward, it's already possible to build -linkshared binaries without a runtime. I expect most of the work is careful argument construction in cmd/go.

@crawshaw crawshaw changed the title from Drop runtime from plugins to cmd/go: drop runtime from plugins Sep 18, 2016

@quentinmit quentinmit added the NeedsFix label Oct 3, 2016

@quentinmit quentinmit added this to the Go1.8 milestone Oct 3, 2016

@rsc

This comment has been minimized.

Contributor

rsc commented Oct 21, 2016

@crawshaw, still want to do this for Go 1.8?

@crawshaw

This comment has been minimized.

Contributor

crawshaw commented Oct 21, 2016

Pushing to 1.9, so I can spend what cycles I have on bugs.

@gopherbot

This comment has been minimized.

gopherbot commented Sep 11, 2017

Change https://golang.org/cl/62352 mentions this issue: cmd/link: correct symbol table order for plugin-use code on darwin/amd64

@crawshaw

This comment has been minimized.

Contributor

crawshaw commented Sep 23, 2017

@hirochachacha at one point you had a CL exploring removing the runtime from plugins. Are you still working on it?

@hirochachacha

This comment has been minimized.

Contributor

hirochachacha commented Sep 23, 2017

@crawshaw No, I'm afraid not.

@rsc rsc modified the milestones: Go1.10, Unplanned Dec 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment