Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: Conn.Close doesn't unblock Conn.Read on nacl #17695

Closed
bradfitz opened this issue Oct 31, 2016 · 2 comments
Closed

net: Conn.Close doesn't unblock Conn.Read on nacl #17695

bradfitz opened this issue Oct 31, 2016 · 2 comments
Assignees
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Oct 31, 2016

It appears that on nacl, a net.Conn.Close (on a "TCP" localhost conn) doesn't unblock a pending Conn.Read.

I thought we had a test for this and it worked, but I'm probably remembering a similar case instead.

Add a test & fix.

Failing higher-level test (skipped for now) is in net/http's TestServerSetKeepAlivesEnabledClosesConns.

Low priority (nacl).

@bradfitz bradfitz added this to the Go1.8Maybe milestone Oct 31, 2016
@bradfitz bradfitz self-assigned this Oct 31, 2016
@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Nov 2, 2016

Good for freeze I guess. That code should be going into syscall/net_nacl.go's netFile and then byteq.read and .close, and as far as I can tell, a close should be waking up a read.

@quentinmit quentinmit added the NeedsFix label Nov 8, 2016
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 15, 2016

CL https://golang.org/cl/33242 mentions this issue.

@gopherbot gopherbot closed this in 9be14c4 Nov 15, 2016
@golang golang locked and limited conversation to collaborators Nov 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.