Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image/png: no support for setting and retrieving the PPI/DPI #18365

Open
rgeronimi opened this issue Dec 17, 2016 · 5 comments

Comments

@rgeronimi
Copy link

commented Dec 17, 2016

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go1.7.4 darwin/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/raphaelgeronimi/Local/Others/Go workspace"
GORACE=""
GOROOT="/opt/local/lib/go"
GOTOOLDIR="/opt/local/lib/go/pkg/tool/darwin_amd64"
CC="/usr/bin/clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/zw/0zvr11l11975vn4gk7s4hrx00000gn/T/go-build732769753=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"

What did you do?

I need to mass-produce PNG chart images in high resolution - i.e., PPI at 2x-4x multiple of the default 72 value

What did you expect to see?

A new encoding method and/or an Options field to customize the PPI of the image being encoded. Similarly, extending the image.Config struct to be able to retrieve the PPI of a decoded image.

What did you see instead?

No method found.

I wrote a patch with the missing code. However the public API design needs to be discussed first as a "clean" API - i.e., adding an Options field to the Encode function to perfectly mirror the design of image/jpeg - is unfeasible as it would break the Go 1 compatibility

@dsnet

This comment has been minimized.

Copy link
Member

commented Dec 17, 2016

/cc @nigeltao

@dsnet dsnet added this to the Unplanned milestone Dec 20, 2016

@rgeronimi

This comment has been minimized.

Copy link
Author

commented Dec 21, 2016

The proposal is the following:

(1) In image/png:
Define Options as

type Options struct {
    PPI int
}

Add
EncodeOptions(w io.Writer, m image.Image, **o Options**) error
which would perform the same encoding as Encode(...), plus encode the PPI into the PNG file
Modify the Decode(...) function so that it also returns the PPI into the image.Config result

(2) In image:
Extend the image.Config struct with a new field:
PPI int

What would be left out of my patch is the corresponding PPI support in the image/jpeg library (my project only uses the image/png library). image/gif requires no patches as GIFs do not support PPI.

@nigeltao

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2016

Specifically, the type should probably be called EncodeOptions, to allow us to to define a DecodeOptions at some point (e.g. to specify a destination buffer). That would mean renaming the function to something else, possibly EncodeImage.

Generally, though, PPI is just one example of image metadata, such as EXIF fields (e.g. #4341). There's a discussion of image metadata at #5050, but there's no concrete API proposal yet. I'd rather solve the general problem than specifically adding a PPI mechanism.

@rgeronimi

This comment has been minimized.

Copy link
Author

commented Dec 22, 2016

I agree this is only a subpart of the metadata issue.

@zxbit2011

This comment has been minimized.

Copy link

commented Apr 17, 2019

How to solve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.