Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
image/png: no support for setting and retrieving the PPI/DPI #18365
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
What operating system and processor architecture are you using (go env)?
What did you do?
I need to mass-produce PNG chart images in high resolution - i.e., PPI at 2x-4x multiple of the default 72 value
What did you expect to see?
A new encoding method and/or an Options field to customize the PPI of the image being encoded. Similarly, extending the image.Config struct to be able to retrieve the PPI of a decoded image.
What did you see instead?
No method found.
I wrote a patch with the missing code. However the public API design needs to be discussed first as a "clean" API - i.e., adding an Options field to the Encode function to perfectly mirror the design of image/jpeg - is unfeasible as it would break the Go 1 compatibility
The proposal is the following:
(1) In image/png:
(2) In image:
What would be left out of my patch is the corresponding PPI support in the image/jpeg library (my project only uses the image/png library). image/gif requires no patches as GIFs do not support PPI.
Specifically, the type should probably be called EncodeOptions, to allow us to to define a DecodeOptions at some point (e.g. to specify a destination buffer). That would mean renaming the function to something else, possibly EncodeImage.
Generally, though, PPI is just one example of image metadata, such as EXIF fields (e.g. #4341). There's a discussion of image metadata at #5050, but there's no concrete API proposal yet. I'd rather solve the general problem than specifically adding a PPI mechanism.