Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
database/sql: flaky test TestTxContextWait #19024
(see on trybots of https://go-review.googlesource.com/c/36219/)
More of #18115?
…t waits with checks When testing context cancelation behavior do not rely on context timeouts. Use explicit checks in all such tests. In closeDB convert the simple check for zero open conns with a wait loop for zero open conns. Fixes #19024 Fixes #19041 Change-Id: Iecfcc4467e91249fceb21ffd1f7c62c58140d8e9 Reviewed-on: https://go-review.googlesource.com/36902 Run-TryBot: Daniel Theophanes <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org> Reviewed-by: Russ Cox <email@example.com> Reviewed-on: https://go-review.googlesource.com/36917 Run-TryBot: Brad Fitzpatrick <firstname.lastname@example.org> Reviewed-by: Daniel Theophanes <email@example.com>