Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database/sql: flaky test TestTxContextWait #19024

Closed
bradfitz opened this issue Feb 10, 2017 · 4 comments
Closed

database/sql: flaky test TestTxContextWait #19024

bradfitz opened this issue Feb 10, 2017 · 4 comments
Assignees

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Feb 10, 2017

https://storage.googleapis.com/go-build-log/779cc599/linux-amd64-race_8fa25f3c.log

--- FAIL: TestTxContextWait (0.02s)
	sql_test.go:395: context deadline exceeded
FAIL
FAIL	database/sql	0.924s

(see on trybots of https://go-review.googlesource.com/c/36219/)

More of #18115?

/cc @rsc

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 10, 2017

CL https://golang.org/cl/36790 mentions this issue.

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 10, 2017

CL https://golang.org/cl/36794 mentions this issue.

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 12, 2017

CL https://golang.org/cl/36902 mentions this issue.

@gopherbot gopherbot closed this in 50ab37d Feb 13, 2017
@gopherbot
Copy link

@gopherbot gopherbot commented Feb 13, 2017

CL https://golang.org/cl/36917 mentions this issue.

gopherbot pushed a commit that referenced this issue Feb 13, 2017
…t waits with checks

When testing context cancelation behavior do not rely on context
timeouts. Use explicit checks in all such tests. In closeDB
convert the simple check for zero open conns with a wait loop
for zero open conns.

Fixes #19024
Fixes #19041

Change-Id: Iecfcc4467e91249fceb21ffd1f7c62c58140d8e9
Reviewed-on: https://go-review.googlesource.com/36902
Run-TryBot: Daniel Theophanes <kardianos@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-on: https://go-review.googlesource.com/36917
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Daniel Theophanes <kardianos@gmail.com>
@golang golang locked and limited conversation to collaborators Feb 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.