Missing API http.Server.ListenAndServeTLS()

[gopherbot]

by bique.alexandre:

Hi,

The http package need an additionnal method to Server :


func (server *Server) ListenAndServeTLS(certFile string, keyFile string) os.Error {
    config := &tls.Config{
    Rand:       rand.Reader,
    Time:       time.Seconds,
    NextProtos: []string{"http/1.1"},
    }

    var err os.Error
    config.Certificates = make([]tls.Certificate, 1)
    config.Certificates[0], err = tls.LoadX509KeyPair(certFile, keyFile)
    if err != nil {
        return err
    }

    conn, err := net.Listen("tcp", server.Addr)
    if err != nil {
        return err
    }

    tlsListener := tls.NewListener(conn, config)
    return server.Serve(tlsListener)
}

[rsc]

Comment 1:

I thought we had addressed this somehow.

Owner changed to @bradfitz.

Status changed to Accepted.

[gopherbot]

Comment 2 by bique.alexandre:

Yes there is a function which does it, but it has no Server context and then no timeout
on read/write.

[bradfitz]

Comment 3:

I guess we could make a new function for it, but it's already possible to just setup
your own tls.Listener and call Server.Serve(net.Listener).
Even if we made a new method on Server, you'd still have to do it by hand if you wanted
to:
  -- setup new NextProtos (e.g. SPDY)
  -- add more than 1 cert
  -- get your certs from somewhere other than disk
I guess those are all rare.

[gopherbot]

Comment 4 by bique.alexandre:

Then I would suggest to remove the default function ListenAndServeTLS and just have it
as a method of Server.
Because you can customize the Server object, and ListenAndServeTLS() function is limited
to it's parameters.

[bradfitz]

Comment 5:

http://golang.org/cl/4630045/

[gopherbot]

Comment 6 by bique.alexandre:

Thank you bradfitz :)

[bradfitz]

Comment 7:

This issue was closed by revision c278434.

Status changed to Fixed.