Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/crypto/sha3: add Keccak 256 support #19709
Ethereum and other crypto chains use the "original" Keccak hash. The difference is a dsbyte of 1 instead of 6 as in
Can we support this Hash in the library or allow the specification of the domain separation byte in some way?
I'm not a member of the Go team and this my personal opinion.
Adam (@agl) once said:
I'm not sure whether it's worth to add a new keccak package - probably not. It would be basically a copy of the sha3 package - but of course @agl has to decide about this.
@FiloSottile Just saw this, wow :)
That said, could we also have
PS: @splix The link posted above is not from the upstream Ethereum project, rather the ETC fork of it.
Keccak uses a different domain separation byte as the NIST- standardized SHA-3 hashing function. Fixes golang/go#19709 Change-Id: I1b45afce9b7719241b24bbdc9b67718d73b457d3 GitHub-Last-Rev: 4f2a701 GitHub-Pull-Request: golang#41 Reviewed-on: https://go-review.googlesource.com/106462 Run-TryBot: Filippo Valsorda <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-by: Filippo Valsorda <firstname.lastname@example.org>