x/build: get Alpine builders passing

[bradfitz]

Thanks to @jessfraz's setting up an Alpine Linux builder (#17891), we now get to deal with more bugs, like this one:

https://build.golang.org/log/09a1850a53ff39d403984ecc8c29114ecd0a4109

--- FAIL: TestCgoPprofPIE (8.39s)
	crash_cgo_test.go:285: signal: segmentation fault (core dumped)
FAIL
FAIL	runtime	16.270s

@ianlancetaylor?

[jessfraz]

I feel like I know why this is happening... I can debug

[jessfraz]

So it's because https://github.com/golang/go/blob/master/src/cmd/link/internal/amd64/obj.go#L70

ld.Thearch.Linuxdynld = "/lib64/ld-linux-x86-64.so.2"

on alpine this is:

ld.Thearch.Linuxdynld = "/lib/ld-musl-x86_64.so.1"

we should maybe have a way of using a different one? but alpine is not a GOOS so unsure what you all would want here

This is #18243

[jessfraz]

There are other failures following that failure as well. Details below.

EDIT: These are all #14481

TestTestEmpty

--- FAIL: TestTestEmpty (1.82s)
    --- FAIL: TestTestEmpty/pkg (1.82s)
        go_test.go:260: running testgo [test -cover -coverpkg=. -race]
        go_test.go:279: standard error:
        go_test.go:280: # runtime/race
                race_linux_amd64.syso: In function `__sanitizer::InternalAlloc(unsigned long, __sanitizer::SizeClassAllocatorLocalCache<__sanitizer::SizeClassAllocator32<0ul, 140737488355328ull, 0ul, __sanitizer::SizeClassMap<3ul, 4ul, 8ul, 17ul, 64ul, 14ul>, 20ul, __sanitizer::TwoLevelByteMap<32768ull, 4096ull, __sanitizer::NoOpMapUnmapCallback>, __sanitizer::NoOpMapUnmapCallback> >*, unsigned long)':
                gotsan.cc:(.text+0x16e1): undefined reference to `__libc_malloc'
                race_linux_amd64.syso: In function `__sanitizer::GetArgv()':
                gotsan.cc:(.text+0x4543): undefined reference to `__libc_stack_end'
                race_linux_amd64.syso: In function `__sanitizer::InternalRealloc(void*, unsigned long, __sanitizer::SizeClassAllocatorLocalCache<__sanitizer::SizeClassAllocator32<0ul, 140737488355328ull, 0ul, __sanitizer::SizeClassMap<3ul, 4ul, 8ul, 17ul, 64ul, 14ul>, 20ul, __sanitizer::TwoLevelByteMap<32768ull, 4096ull, __sanitizer::NoOpMapUnmapCallback>, __sanitizer::NoOpMapUnmapCallback> >*)':
                gotsan.cc:(.text+0x7dd0): undefined reference to `__libc_realloc'
                race_linux_amd64.syso: In function `__sanitizer::ReExec()':
                gotsan.cc:(.text+0xed47): undefined reference to `__libc_stack_end'
                race_linux_amd64.syso: In function `__sanitizer::InternalFree(void*, __sanitizer::SizeClassAllocatorLocalCache<__sanitizer::SizeClassAllocator32<0ul, 140737488355328ull, 0ul, __sanitizer::SizeClassMap<3ul, 4ul, 8ul, 17ul, 64ul, 14ul>, 20ul, __sanitizer::TwoLevelByteMap<32768ull, 4096ull, __sanitizer::NoOpMapUnmapCallback>, __sanitizer::NoOpMapUnmapCallback> >*)':
                gotsan.cc:(.text+0x7438): undefined reference to `__libc_free'
                collect2: error: ld returned 1 exit status
    
        go_test.go:289: go [test -cover -coverpkg=. -race] failed unexpectedly: exit status 2

TestTestRaceInstall

--- FAIL: TestTestRaceInstall (1.99s)
        go_test.go:260: running testgo [install -race -pkgdir=/tmp/gotest207241282/pkg std]
        go_test.go:279: standard error:
        go_test.go:280: # runtime/race
                race_linux_amd64.syso: In function `__sanitizer::InternalAlloc(unsigned long, __sanitizer::SizeClassAllocatorLocalCache<__sanitizer::SizeClassAllocator32<0ul, 140737488355328ull, 0ul, __sanitizer::SizeClassMap<3ul, 4ul, 8ul, 17ul, 64ul, 14ul>, 20ul, __sanitizer::TwoLevelByteMap<32768ull, 4096ull, __sanitizer::NoOpMapUnmapCallback>, __sanitizer::NoOpMapUnmapCallback> >*, unsigned long)':
                gotsan.cc:(.text+0x16e1): undefined reference to `__libc_malloc'
                race_linux_amd64.syso: In function `__sanitizer::GetArgv()':
                gotsan.cc:(.text+0x4543): undefined reference to `__libc_stack_end'
                race_linux_amd64.syso: In function `__sanitizer::InternalRealloc(void*, unsigned long, __sanitizer::SizeClassAllocatorLocalCache<__sanitizer::SizeClassAllocator32<0ul, 140737488355328ull, 0ul, __sanitizer::SizeClassMap<3ul, 4ul, 8ul, 17ul, 64ul, 14ul>, 20ul, __sanitizer::TwoLevelByteMap<32768ull, 4096ull, __sanitizer::NoOpMapUnmapCallback>, __sanitizer::NoOpMapUnmapCallback> >*)':
                gotsan.cc:(.text+0x7dd0): undefined reference to `__libc_realloc'
                race_linux_amd64.syso: In function `__sanitizer::ReExec()':
                gotsan.cc:(.text+0xed47): undefined reference to `__libc_stack_end'
                race_linux_amd64.syso: In function `__sanitizer::InternalFree(void*, __sanitizer::SizeClassAllocatorLocalCache<__sanitizer::SizeClassAllocator32<0ul, 140737488355328ull, 0ul, __sanitizer::SizeClassMap<3ul, 4ul, 8ul, 17ul, 64ul, 14ul>, 20ul, __sanitizer::TwoLevelByteMap<32768ull, 4096ull, __sanitizer::NoOpMapUnmapCallback>, __sanitizer::NoOpMapUnmapCallback> >*)':
                gotsan.cc:(.text+0x7438): undefined reference to `__libc_free'
                collect2: error: ld returned 1 exit status

        go_test.go:289: go [install -race -pkgdir=/tmp/gotest207241282/pkg std] failed unexpectedly: exit status 2

TestGoTestRaceInstallCgo

--- FAIL: TestGoTestRaceInstallCgo (1.90s)
        go_test.go:260: running testgo [tool -n cgo]
        go_test.go:275: standard output:
        go_test.go:276: /usr/src/go/pkg/tool/linux_amd64/cgo

        go_test.go:260: running testgo [test -race -i runtime/race]
        go_test.go:279: standard error:
        go_test.go:280: # runtime/race
                race_linux_amd64.syso: In function `__sanitizer::InternalAlloc(unsigned long, __sanitizer::SizeClassAllocatorLocalCache<__sanitizer::SizeClassAllocator32<0ul, 140737488355328ull, 0ul, __sanitizer::SizeClassMap<3ul, 4ul, 8ul, 17ul, 64ul, 14ul>, 20ul, __sanitizer::TwoLevelByteMap<32768ull, 4096ull, __sanitizer::NoOpMapUnmapCallback>, __sanitizer::NoOpMapUnmapCallback> >*, unsigned long)':
                gotsan.cc:(.text+0x16e1): undefined reference to `__libc_malloc'
                race_linux_amd64.syso: In function `__sanitizer::GetArgv()':
                gotsan.cc:(.text+0x4543): undefined reference to `__libc_stack_end'
                race_linux_amd64.syso: In function `__sanitizer::InternalRealloc(void*, unsigned long, __sanitizer::SizeClassAllocatorLocalCache<__sanitizer::SizeClassAllocator32<0ul, 140737488355328ull, 0ul, __sanitizer::SizeClassMap<3ul, 4ul, 8ul, 17ul, 64ul, 14ul>, 20ul, __sanitizer::TwoLevelByteMap<32768ull, 4096ull, __sanitizer::NoOpMapUnmapCallback>, __sanitizer::NoOpMapUnmapCallback> >*)':
                gotsan.cc:(.text+0x7dd0): undefined reference to `__libc_realloc'
                race_linux_amd64.syso: In function `__sanitizer::ReExec()':
                gotsan.cc:(.text+0xed47): undefined reference to `__libc_stack_end'
                race_linux_amd64.syso: In function `__sanitizer::InternalFree(void*, __sanitizer::SizeClassAllocatorLocalCache<__sanitizer::SizeClassAllocator32<0ul, 140737488355328ull, 0ul, __sanitizer::SizeClassMap<3ul, 4ul, 8ul, 17ul, 64ul, 14ul>, 20ul, __sanitizer::TwoLevelByteMap<32768ull, 4096ull, __sanitizer::NoOpMapUnmapCallback>, __sanitizer::NoOpMapUnmapCallback> >*)':
                gotsan.cc:(.text+0x7438): undefined reference to `__libc_free'
                collect2: error: ld returned 1 exit status

        go_test.go:289: go [test -race -i runtime/race] failed unexpectedly: exit status 2

TestGoTestRaceFailures

--- FAIL: TestGoTestRaceFailures (0.69s)
        go_test.go:260: running testgo [test testrace]
        go_test.go:275: standard output:
        go_test.go:276: ok      testrace        0.002s

        go_test.go:260: running testgo [test -race testrace]
        go_test.go:275: standard output:
        go_test.go:276: FAIL    testrace [build failed]

        go_test.go:279: standard error:
        go_test.go:280: # runtime/race
                race_linux_amd64.syso: In function `__sanitizer::InternalAlloc(unsigned long, __sanitizer::SizeClassAllocatorLocalCache<__sanitizer::SizeClassAllocator32<0ul, 140737488355328ull, 0ul, __sanitizer::SizeClassMap<3ul, 4ul, 8ul, 17ul, 64ul, 14ul>, 20ul, __sanitizer::TwoLevelByteMap<32768ull, 4096ull, __sanitizer::NoOpMapUnmapCallback>, __sanitizer::NoOpMapUnmapCallback> >*, unsigned long)':
                gotsan.cc:(.text+0x16e1): undefined reference to `__libc_malloc'
                race_linux_amd64.syso: In function `__sanitizer::GetArgv()':
                gotsan.cc:(.text+0x4543): undefined reference to `__libc_stack_end'
                race_linux_amd64.syso: In function `__sanitizer::InternalRealloc(void*, unsigned long, __sanitizer::SizeClassAllocatorLocalCache<__sanitizer::SizeClassAllocator32<0ul, 140737488355328ull, 0ul, __sanitizer::SizeClassMap<3ul, 4ul, 8ul, 17ul, 64ul, 14ul>, 20ul, __sanitizer::TwoLevelByteMap<32768ull, 4096ull, __sanitizer::NoOpMapUnmapCallback>, __sanitizer::NoOpMapUnmapCallback> >*)':
                gotsan.cc:(.text+0x7dd0): undefined reference to `__libc_realloc'
                race_linux_amd64.syso: In function `__sanitizer::ReExec()':
                gotsan.cc:(.text+0xed47): undefined reference to `__libc_stack_end'
                race_linux_amd64.syso: In function `__sanitizer::InternalFree(void*, __sanitizer::SizeClassAllocatorLocalCache<__sanitizer::SizeClassAllocator32<0ul, 140737488355328ull, 0ul, __sanitizer::SizeClassMap<3ul, 4ul, 8ul, 17ul, 64ul, 14ul>, 20ul, __sanitizer::TwoLevelByteMap<32768ull, 4096ull, __sanitizer::NoOpMapUnmapCallback>, __sanitizer::NoOpMapUnmapCallback> >*)':
                gotsan.cc:(.text+0x7438): undefined reference to `__libc_free'
                collect2: error: ld returned 1 exit status

        go_test.go:299: testgo failed as expected: exit status 2
        go_test.go:365: TestRace did not fail
        go_test.go:366: pattern FAIL: TestRace not found in standard output
FAIL

[jessfraz]

Lastly there is:

--- FAIL: TestGroupCleanup (0.00s)
        exec_linux_test.go:214: id command output: "uid=0(root) gid=0(root)", expected prefix: "uid=0(root) gid=0(root) groups=0(root)"
--- FAIL: TestGroupCleanupUserNamespace (0.00s)
        exec_linux_test.go:256: id command output: "uid=0(root) gid=0(root) groups=0(root),65534(nobody),65534(nobody),65534(nobody),65534(nobody),65534(nobody),65534(nobody),65534(nobody),65534(nobody),65534(nobody),65534(nobody)", expected one of ["uid=0(root) gid=0(root) groups=0(root)" "uid=0(root) gid=0(root) groups=0(root),65534(nobody)" "uid=0(root) gid=0(root) groups=0(root),65534(nogroup)" "uid=0(root) gid=0(root) groups=0(root),65534"]
FAIL

which I can open a CL to fix

[gopherbot]

CL https://golang.org/cl/40692 mentions this issue.

[bradfitz]

Should we run the Alpine builder with CGO_ENABLED=0 perhaps?

[ianlancetaylor]

@bradfitz That seems reasonable until we have a fix for #18243.

[gopherbot]

CL https://golang.org/cl/41628 mentions this issue.

[gopherbot]

CL https://golang.org/cl/41675 mentions this issue.