assume HTTP/1.1 for the zero value of Request ProtoMajor/ProtoMinor?

[bradfitz]

Right now, http.Request.ProtoAtLeast(1, 1) returns false if ProtoMajor and ProtoMinor
are unset.

In embracing the zero value, could/should we special case 0,0 to mean 1,1?  Users could
still set 0,9 if they wanted (HTTP/0.9 was the first protocol version).

I wasted some time debugging an issue with this today.

Russ?

[dsymonds]

Comment 1:

My 2¢.
http.NewRequest already sets ProtoMajor/ProtoMinor to 1, and http.ReadRequest populates
those fields, so I'm guessing you were constructing the HTTP Request manually.
I'm wary of special-casing 0,0 in one place that would otherwise be a simple convenience
wrapper. I don't have an alternative that would have made your life easier, but here are
some weak ideas that come to mind:
  - a method on http.Request that tells you whether it's valid
  - a method on http.Request that fills in its default values (but that's what http.NewRequest already does)
  - log a message in ProtoAtLeast if it's 0,0
I tend to look at the type definition if I'm writing out a composite literal, and make
sure to fill in relevant fields in that order. Maybe this is one of those cases where
programmer habit is better than programmatic enforcement.

[rsc]

Comment 2:

I agree with David.  How did this come up?

[bradfitz]

Comment 3:

I was manually creating one.  Not a big deal.

Status changed to Retracted.