Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/trace: use std context package #20056

Closed
gyuho opened this issue Apr 20, 2017 · 8 comments
Closed

x/net/trace: use std context package #20056

gyuho opened this issue Apr 20, 2017 · 8 comments

Comments

@gyuho
Copy link
Contributor

gyuho commented Apr 20, 2017

Can we have context here https://github.com/golang/net/blob/master/trace/trace.go#L80?

This golang/time@c06e80d happened. Would the same change in trace break anything?

It's one of our sub-dependency and would like to know when this would happen :)

Thanks in advance!

@gyuho gyuho mentioned this issue Apr 20, 2017
26 tasks
@bradfitz bradfitz changed the title context: 'net/trace' still imports 'golang.org/x/net/context' x/net/trace: use std context package Apr 20, 2017
@gopherbot gopherbot added this to the Unreleased milestone Apr 20, 2017
@gopherbot
Copy link

CL https://golang.org/cl/41290 mentions this issue.

@dfawley
Copy link

dfawley commented Apr 21, 2017

This is a cascading problem. grpc-go is now broken since this package is a dependency of ours and we support Go 1.6. We are blocked on deprecating 1.6 and updating our imports until generated proto files use the standard context package. AppEngine only supports Go1.6, so I believe the proto compiler can't be changed until that is updated.

Is it possible to revert these context changes and hold off on them until Go1.6 is less widely used?

@bradfitz
Copy link
Contributor

@dfawley, where is the grpc-go breakage? Got some URLs?

@dfawley
Copy link

dfawley commented Apr 21, 2017

Our tests only run on PRs and merges, so the main page doesn't show this breakage. Here's an example from an in-progress PR:

https://travis-ci.org/grpc/grpc-go/jobs/224274230#L215

@broady
Copy link
Member

broady commented Apr 21, 2017

+1 on being affected by breakage. This breaks Google Cloud client libraries using gRPC on App Engine standard, which is stuck on Go 1.6.

@bradfitz
Copy link
Contributor

It's been 14 months since Go 1.6. App Engine can't get another release out? Is that really what this is all about?

Go's policy is that we only test and maintain the past two releases. I could add some build tag chicanery into x/net/trace, but our builders aren't testing 1.6 anymore. I don't want to revert the change. We want to make forward progress on cleanups and other people want us to use std context.

Let me see what I can do.

@bradfitz
Copy link
Contributor

@scottma
Copy link

scottma commented Apr 23, 2017

yak, getting this error now after this change .

golang.org/x/net/trace/trace.go:67: can't find import: "context"

gopherbot pushed a commit to golang/net that referenced this issue Apr 23, 2017
App Engine is stuck 14 months in the past and doesn't have context.

Updates golang/go#20056

Change-Id: I2cb2a3a75af07728805be8c714e4725f01a17074
Reviewed-on: https://go-review.googlesource.com/41413
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Apr 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants