Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
x/net/trace: use std context package #20056
Can we have
This golang/time@c06e80d happened. Would the same change in
It's one of our sub-dependency and would like to know when this would happen :)
Thanks in advance!
changed the title from
context: 'net/trace' still imports 'golang.org/x/net/context'
x/net/trace: use std context package
Apr 20, 2017
This is a cascading problem. grpc-go is now broken since this package is a dependency of ours and we support Go 1.6. We are blocked on deprecating 1.6 and updating our imports until generated proto files use the standard context package. AppEngine only supports Go1.6, so I believe the proto compiler can't be changed until that is updated.
Is it possible to revert these context changes and hold off on them until Go1.6 is less widely used?
Our tests only run on PRs and merges, so the main page doesn't show this breakage. Here's an example from an in-progress PR:
It's been 14 months since Go 1.6. App Engine can't get another release out? Is that really what this is all about?
Go's policy is that we only test and maintain the past two releases. I could add some build tag chicanery into x/net/trace, but our builders aren't testing 1.6 anymore. I don't want to revert the change. We want to make forward progress on cleanups and other people want us to use std context.
Let me see what I can do.