HTTP Conn needs a timeout

[gopherbot]

by david.titarenco:

What steps will reproduce the problem?

func HelloServer(c *http.Conn, req *http.Request) {
        for {
                io.WriteString(c, "This is the song that never ends. );
                c.Flush();
        }
}

What is the expected output? What do you see instead?
As a rule of thumb, HTTP servers (and most network servers in general) have
timeouts to prevent infinite-length connections. A timeout goroutine is
necessary to prevent high-volume fd saturation.

What is your $GOOS?  $GOARCH?
GOARCH=386
GOROOT=/home/go
GOOS=linux

Which revision are you sync'ed to?  (hg log -l 1)
4065:ce0a8285caf5

Please provide any additional information below.
I'm working on an implementation of this.

[gopherbot]

Comment 1 by david.titarenco:

CL: http://golang.org/cl/155060

[rsc]

Comment 2:

Owner changed to r...@golang.org.

Status changed to Accepted.

[rsc]

Comment 3:

Labels changed: added packagechange.

[bradfitz]

Comment 4:

Now that we have the http.Server struct, we at least have a place to put this option.
But I'm not sure what it helps.  It certainly wouldn't help the example above since it'd
then just spin forever which is arguably worse than a fd shortage.  A fd shortage isn't
even quite realistic nowadays.  I've done hundreds of thousands of fds in a single
process on a moderate machine years ago.
I feel that anybody who wants a timeout on a handler could wrap it in another Handler
that used a time.Timer to send an error to the client at least.  But in lieu of ways to
kill fellow goroutines forcefully (which opens up a huge can of worms), I don't really
see anything to do here.

[bradfitz]

Comment 5:

Labels changed: added pkg-http.

Owner changed to @bradfitz.

[bradfitz]

Comment 6:

This issue was closed by revision 4787e70.

Status changed to Fixed.