archive/zip: Header<->os.FileInfo functions

[mark-summerfield]

The zip package has a FileHeader struct that uses the fields required by zip files.
Unfortunately these fields do not map nicely to os.FileInfo fields.

I think it would be helpful to provide conversion functions:

zip.HeaderForInfo(*os.FileInfo) *zip.FileHeader
zip.InfoForHeader(*zip.FileHeader) *.os.FileInfo

This would be particularly convenient when it comes to date/time and permissions
handling.

Similar functions would also be helpful (but not as necesary) in the tar package.

[mark-summerfield]

Comment 1:

Of course, even better would be *zip.FileHeader methods:
zip.FileHeader.FileInfo() *os.FileInfo
zip.FileHeader.Populate(*os.FileInfo)

[adg]

Comment 2:

Agree this would be very useful.

Owner changed to @adg.

Status changed to Accepted.

[rsc]

Comment 3:

The *For* names are not idiomatic.
It should be a FileInfo method on the zip file header.

[rsc]

Comment 4:

This will be partly addressed by FileInfo becoming an interface.

[rsc]

Comment 6:

Labels changed: added priority-later, removed priority-medium.

[rsc]

Comment 7:

Labels changed: added priority-go1.

[robpike]

Comment 8:

Owner changed to builder@golang.org.

[rsc]

Comment 9:

Maybe
func (*Header) FileInfo() os.FileInfo
func FileInfoHeader(os.FileInfo) *Header

[bradfitz]

Comment 10:

Owner changed to @bradfitz.

Status changed to Started.

[bradfitz]

Comment 11:

This issue was closed by revision b62a509.

Status changed to Fixed.