sync/atomic fails to build correctly on windows

[gopherbot]

by Paul.A.Lalonde:

From all.bash sync/atomic fails on my Windows 7 build under MinGW.  It seems that in
Make.pkg the mkdir -p fails, and so the subsequent copy fails.
Quoting the argument at Make.pkg:82 fixes the problem

What steps will reproduce the problem?
1.  Make GOROOT include the drive letter prefix; mine is
"C:/MinGW/msys/1.0/home/plalonde/go"
2. Run all.bash


What is the expected output?
Complete build

What do you see instead?
Failed install of sync/atomic from a failed copy from a missing sync/atomic subdirectory.

Which compiler are you using (5g, 6g, 8g, gccgo)?


Which operating system are you using?
Win7

Which revision are you using?  (hg identify)
6eb2b9dbe489+ weekly/weekly.2011-08-17

Please provide any additional information below.
Quoting the parameter to mkdir -p fixes the problem; tests on linux shows it does not
break the linux build.

[rsc]

Comment 1:

Can you please show the command make ran
and the output?  I don't understand why that
path needs quoting.  Is it because of the / ?

[gopherbot]

Comment 2 by Paul.A.Lalonde:

Here's the relevant part of the output:
%%%% making pkg %%%%
make: Entering directory `C:/MinGW/msys/1.0/home/plalonde/go/src/pkg'
install runtime
install sync/atomic
install unicode
install math
INSTALL FAIL sync/atomic
make[1]: Entering directory `C:/MinGW/msys/1.0/home/plalonde/go/src/pkg/sync/atomic'
8g  -o _go_.8 doc.go
8a asm_386.s
rm -f _obj/sync/atomic.a
gopack grc _obj/sync/atomic.a _go_.8 asm_386.8
mkdir -p C:/MinGW/msys/1.0/home/plalonde/go/pkg/windows_386/sync
cp _obj/sync/atomic.a "C:/MinGW/msys/1.0/home/plalonde/go/pkg/windows_386/sync/atomic.a"
cp: cannot create regular file
`C:/MinGW/msys/1.0/home/plalonde/go/pkg/windows_386/sync/atomic.a': No such file or
directory
make[1]: *** [C:/MinGW/msys/1.0/home/plalonde/go/pkg/windows_386/sync/atomic.a] Error 1
make[1]: Leaving directory `C:/MinGW/msys/1.0/home/plalonde/go/src/pkg/sync/atomic'
make: *** [sync/atomic.install] Error 1
make: *** Waiting for unfinished jobs....
make: Leaving directory `C:/MinGW/msys/1.0/home/plalonde/go/src/pkg'
plalonde@plalonde-DESK1 ~/go/src
$ echo $GOROOT
c:\mingw\msys\1.0\home\plalonde\go
I get the same result if GOROOT has forward slashes, if I match case exaclty, and
everything else I could think of.
However, if I quote the argument to mkdir -p, it works fine.  
Colour me confused.

[rsc]

Comment 3:

Do you see the same 'must have quotes' behavior
on the command line?  My guess is that the quotes
make mkdir work better because it doesn't interpret
the /sync as a command-line flag.  Even if you put \
in $GOROOT you wouldn't get a \ before sync
during the make.

[gopherbot]

Comment 4 by Paul.A.Lalonde:

No, I don't get the same from the command line, which caused me a pile of grief finding
this in the first place - I could run the commands by hand and have them succeed, but
not from within the Makefile.  I just tested it again, and found the same.
Oddly, the makefile quotes the second parameter to the cp on the following line.

[alexbrainman]

Comment 5:

I had similar problem. mkdir "-p" flag does not work for some paths:
http://golang.org/cl/4626087#msg9
I think if you set GOROOT=/C/MinGW/go, you will be OK.

Owner changed to @alexbrainman.

Status changed to WaitingForReply.

[alexbrainman]

Comment 6:

Status changed to TimedOut.