Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/time: update tzdata before release #22487

Open
tklauser opened this issue Oct 29, 2017 · 17 comments

Comments

Projects
None yet
6 participants
@tklauser
Copy link
Member

commented Oct 29, 2017

The timezone database in lib/time should be updated shortly before the 1.10 release (to whatever tzdata release is current then). There was https://golang.org/cl/74230 attempting to do this just now, but it was too early. @ALTree suggested to open an issue about this, so we don't forget.

@ALTree ALTree added this to the Go1.10 milestone Oct 29, 2017

@ALTree ALTree added the NeedsFix label Oct 29, 2017

@gopherbot

This comment has been minimized.

Copy link

commented Dec 6, 2017

Change https://golang.org/cl/74230 mentions this issue: lib/time: update tzdata to 2017c

gopherbot pushed a commit that referenced this issue Dec 6, 2017

lib/time: update tzdata to 2017c
Update the tzdata database to version 2017c (released 2017-10-20).

Updates #22487

Change-Id: If58ff89173ef1f1044075505f42ff132b57795f0
Reviewed-on: https://go-review.googlesource.com/74230
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@bradfitz

This comment has been minimized.

Copy link
Member

commented Jan 4, 2018

2017c is still the latest. Will regarget to Go 1.11.

@bradfitz bradfitz modified the milestones: Go1.10, Go1.11 Jan 4, 2018

@bradfitz bradfitz changed the title lib/time: update tzdata before 1.10 release lib/time: update tzdata before release Jan 4, 2018

@ksshannon

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2018

2018a came out a few days ago:

https://www.iana.org/time-zones

I'm assuming it's too late in the cycle, but just thought I'd post.

@ALTree

This comment has been minimized.

Copy link
Member

commented Jan 16, 2018

That's weird, they didn't even announce it in the mailing list: http://mm.icann.org/pipermail/tz-announce/

Anyway I've looked at the CHANGELOG and there are a few changes in the timezones data, here's the short version:

Release 2018a

  - São Tomé and Príncipe switched from +00 to +01.
  - Brazil's DST will now start on November's first Sunday.
  - Ireland's standard time is now in the summer, not the winter.

We could try to update it and see if anything breaks (usually it's the tests). If everything is fine, maybe it could be shipped with go1.10

@ALTree

This comment has been minimized.

Copy link
Member

commented Jan 16, 2018

At the moment our update script is broken because the 2018a release is not yet published at https://data.iana.org/time-zones/releases/, which is the place we visit to download the data. Considering this (and the fact that the new release wasn't even announced in the tz-announce mailing list) we should probably wait.

@ksshannon

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2018

Agreed, I've downloaded the archives and make fails, so I think it may have issues.

@ksshannon

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2018

There was an issue with the archive, 2018b will be released in a few days:

http://mm.icann.org/pipermail/tz/2018-January/025814.html

@ksshannon

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2018

Another issue with 2018b, but 2018c finally made it to the announce list:

http://mm.icann.org/pipermail/tz-announce/2018-January/000048.html

@bradfitz

This comment has been minimized.

Copy link
Member

commented Jan 23, 2018

Doesn't seem worth doing this late in the cycle. @ianlancetaylor?

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Jan 24, 2018

I have no opinion. I note that there is some disagreement going on about Irish time; I don't know how or whether that was resolved.

@gopherbot

This comment has been minimized.

Copy link

commented Jan 24, 2018

Change https://golang.org/cl/89375 mentions this issue: lib/time: follow redirects in curl

@ksshannon

This comment has been minimized.

Copy link
Contributor

commented Jan 24, 2018

The Irish issue was reverted. It sounded a little messy. It may just be a good idea to wait, but I have no strong opinion either. They did change the location of the archives, which the referenced CL fixes when the tree opens up.

gopherbot pushed a commit that referenced this issue Jan 24, 2018

lib/time: follow redirects in curl
Starting on or about the 2018c archives, www.iana.org is redirected to
data.iana.org.  Tell curl to follow the redirect.

Updates: #22487

Change-Id: I00acada1a3ba01ef701d6d4ffae6cc2cbb6a068f
Reviewed-on: https://go-review.googlesource.com/89375
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot

This comment has been minimized.

Copy link

commented Jun 11, 2018

Change https://golang.org/cl/117855 mentions this issue: lib/time: update vendored tzdata to release 2018e

gopherbot pushed a commit that referenced this issue Jun 11, 2018

lib/time: update vendored tzdata to release 2018e
It has been a long time since the last time the vendored zoneinfo in
lib/time was updated, and we're well into the freeze. Update it to the
lastest release from IANA.

Updates #22487

Change-Id: Ib9a8eb409554848285fc88363dbb04ed9d6d9eb0
Reviewed-on: https://go-review.googlesource.com/117855
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

@tklauser tklauser modified the milestones: Go1.11, Go1.12 Jul 10, 2018

@gopherbot

This comment has been minimized.

Copy link

commented Nov 27, 2018

Change https://golang.org/cl/151299 mentions this issue: lib/time: update tzdata to 2018g

gopherbot pushed a commit that referenced this issue Nov 28, 2018

lib/time: update tzdata to 2018g
Now that the tree has been frozen for some time, update the tzdata
database to version 2018g (released 2018-10-26) for Go 1.12.

Updates #22487

Change-Id: I9e82bcdaef28d308643c08c9fd3472e4c14a196e
Reviewed-on: https://go-review.googlesource.com/c/151299
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

@tklauser tklauser modified the milestones: Go1.12, Go1.13 Nov 28, 2018

@ksshannon

This comment has been minimized.

Copy link
Contributor

commented Jan 4, 2019

Just an update, there have been two more releases since 2018g, 2018i is available as of 2018-12-30:

https://www.iana.org/time-zones

@bradfitz

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

This isn't critical for Go 1.12 but would also be fine to include in Go 1.12 too.

Except when I try to update it, I get awk crashes, even with the tzdata version we already have:

awk -v DATAFORM=`expr main.zi : '\(.*\).zi'` -f ziguard.awk \
          africa antarctica asia australasia europe northamerica southamerica etcetera systemv factory backward  >main.zi.out
*** Error in `awk': malloc(): memory corruption: 0x000055983caeb9c8 ***
======= Backtrace: =========
/lib/x86_64-linux-gnu/libc.so.6(+0x70bfb)[0x7f3863057bfb]
/lib/x86_64-linux-gnu/libc.so.6(+0x76fc6)[0x7f386305dfc6]
/lib/x86_64-linux-gnu/libc.so.6(+0x79089)[0x7f3863060089]
/lib/x86_64-linux-gnu/libc.so.6(__libc_malloc+0x54)[0x7f3863061f64]
awk(+0x119c7)[0x55983c0bb9c7]
awk(+0x730d)[0x55983c0b130d]
awk(+0xfbe0)[0x55983c0b9be0]
awk(+0x82be)[0x55983c0b22be]
awk(+0x2b5f)[0x55983c0acb5f]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf1)[0x7f38630072e1]
awk(+0x2b9a)[0x55983c0acb9a]
======= Memory map: ========
55983c0aa000-55983c0c6000 r-xp 00000000 08:01 401125                     /usr/bin/mawk
55983c2c5000-55983c2c6000 r--p 0001b000 08:01 401125                     /usr/bin/mawk
55983c2c6000-55983c2c8000 rw-p 0001c000 08:01 401125                     /usr/bin/mawk
55983c2c8000-55983c2cc000 rw-p 00000000 00:00 0 
55983cacf000-55983caf0000 rw-p 00000000 00:00 0                          [heap]
7f385c000000-7f385c021000 rw-p 00000000 00:00 0 
7f385c021000-7f3860000000 ---p 00000000 00:00 0 
7f3862dd0000-7f3862de6000 r-xp 00000000 08:01 525224                     /lib/x86_64-linux-gnu/libgcc_s.so.1
7f3862de6000-7f3862fe5000 ---p 00016000 08:01 525224                     /lib/x86_64-linux-gnu/libgcc_s.so.1
7f3862fe5000-7f3862fe6000 r--p 00015000 08:01 525224                     /lib/x86_64-linux-gnu/libgcc_s.so.1
7f3862fe6000-7f3862fe7000 rw-p 00016000 08:01 525224                     /lib/x86_64-linux-gnu/libgcc_s.so.1
7f3862fe7000-7f386317c000 r-xp 00000000 08:01 580558                     /lib/x86_64-linux-gnu/libc-2.24.so
7f386317c000-7f386337c000 ---p 00195000 08:01 580558                     /lib/x86_64-linux-gnu/libc-2.24.so
7f386337c000-7f3863380000 r--p 00195000 08:01 580558                     /lib/x86_64-linux-gnu/libc-2.24.so
7f3863380000-7f3863382000 rw-p 00199000 08:01 580558                     /lib/x86_64-linux-gnu/libc-2.24.so
7f3863382000-7f3863386000 rw-p 00000000 00:00 0 
7f3863386000-7f3863489000 r-xp 00000000 08:01 580575                     /lib/x86_64-linux-gnu/libm-2.24.so
7f3863489000-7f3863688000 ---p 00103000 08:01 580575                     /lib/x86_64-linux-gnu/libm-2.24.so
7f3863688000-7f3863689000 r--p 00102000 08:01 580575                     /lib/x86_64-linux-gnu/libm-2.24.so
7f3863689000-7f386368a000 rw-p 00103000 08:01 580575                     /lib/x86_64-linux-gnu/libm-2.24.so
7f386368a000-7f38636ad000 r-xp 00000000 08:01 580495                     /lib/x86_64-linux-gnu/ld-2.24.so
7f386389c000-7f386389e000 rw-p 00000000 00:00 0 
7f38638a9000-7f38638ad000 rw-p 00000000 00:00 0 
7f38638ad000-7f38638ae000 r--p 00023000 08:01 580495                     /lib/x86_64-linux-gnu/ld-2.24.so
7f38638ae000-7f38638af000 rw-p 00024000 08:01 580495                     /lib/x86_64-linux-gnu/ld-2.24.so
7f38638af000-7f38638b0000 rw-p 00000000 00:00 0 
7ffe2057d000-7ffe2059e000 rw-p 00000000 00:00 0                          [stack]
7ffe205ee000-7ffe205f0000 r--p 00000000 00:00 0                          [vvar]
7ffe205f0000-7ffe205f2000 r-xp 00000000 00:00 0                          [vdso]
ffffffffff600000-ffffffffff601000 r-xp 00000000 00:00 0                  [vsyscall]
Aborted

So I'll let others do this.

/cc @ianlancetaylor

@gopherbot

This comment has been minimized.

Copy link

commented Jan 7, 2019

Change https://golang.org/cl/156637 mentions this issue: lib/time: update tzdata to 2018i

gopherbot pushed a commit that referenced this issue Jan 7, 2019

lib/time: update tzdata to 2018i
Updates #22487

Change-Id: Iab4874ddef8e47eb99cd03e1c40af8372cce65c6
Reviewed-on: https://go-review.googlesource.com/c/156637
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.