Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/signal: TestTerminalSignal is failing on multiple builders #22845

Closed
mundaym opened this issue Nov 22, 2017 · 3 comments
Closed

os/signal: TestTerminalSignal is failing on multiple builders #22845

mundaym opened this issue Nov 22, 2017 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.10

Comments

@mundaym
Copy link
Member

mundaym commented Nov 22, 2017

builder issue example
linux-amd64-clang race between command and ^Z? (only seen once) link
linux-arm race between command and ^Z? link
linux-s390x-ibm test timeout link
android-arm-wiko-fever compilation: could not determine kind of name for C.posix_openpt link
dragonfly-amd64 context timeout link
solaris-amd64-oraclerel no ^Z? link
solaris-amd64-smartosbuildlet compilation: #error "Compiler or options invalid; UNIX 03 and POSIX.1-2001 applications require the use of c99" link

I think the linux-arm and linux-amd64-clang failures are due to the ^Z being issued before the command has started. I experience this locally on linux/s390x and if I increase the duration of the intervening time.Sleep call then the test passes. I suspect we need a more robust mechanism to check the command has started than time.Sleep.

I'm not sure why the linux/s390x builder is timing out. I'll investigate.
@mundaym mundaym added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 22, 2017
@mundaym mundaym added this to the Go1.10 milestone Nov 22, 2017
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/79395 mentions this issue: os/signal: make TestTerminalSignal more reliable

gopherbot pushed a commit that referenced this issue Nov 22, 2017
@ianlancetaylor
os/signal: make TestTerminalSignal more reliable
6ecd843 
Look for program output and shell prompt to see when to continue.

Updates #22845

Change-Id: I44ed1908861f3b0dc098aee9a401324b77268921
Reviewed-on: https://go-review.googlesource.com/79395
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Michael Munday <mike.munday@ibm.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@ianlancetaylor ianlancetaylor mentioned this issue Nov 22, 2017
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/79399 mentions this issue: os/signal: don't run TestTerminalSignal on Android

gopherbot pushed a commit that referenced this issue Nov 23, 2017
@ianlancetaylor @bradfitz
os/signal: don't run TestTerminalSignal on Android
571ee04 
At least some versions of the Android libc do not define posix_openpt.

Updates #22845

Change-Id: Id21705f47ef0f9694313a7dc7351a952d48d407b
Reviewed-on: https://go-review.googlesource.com/79399
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@mundaym
Copy link
Member Author

mundaym commented Nov 24, 2017

I think all the builders are now 'ok' again, thanks Ian.

@mundaym mundaym closed this as completed Nov 24, 2017
@golang golang locked and limited conversation to collaborators Nov 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
3 participants
@ianlancetaylor @gopherbot @mundaym