Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: improve arm64 memclr #22948

Closed
mrosier-qdt opened this issue Nov 30, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@mrosier-qdt
Copy link
Contributor

commented Nov 30, 2017

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.9.2 linux/arm64

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

What did you do?

Identified via inspection.

What did you expect to see?

The implementation can be improved by unrolling loops and using sets of ldp and stp instructions.

What did you see instead?

@bradfitz bradfitz added this to the Unplanned milestone Nov 30, 2017

@mrosier-qdt

This comment has been minimized.

Copy link
Contributor Author

commented Nov 30, 2017

The intent of this bug report is to convey the fact that my team and I are developing an improved version of the memclr routine for arm64. We understand the tree opens for performance work in early February.

@mrosier-qdt

This comment has been minimized.

Copy link
Contributor Author

commented Nov 30, 2017

Thanks, @randall77. I'm fairly new to github issue reporting. Google seems to indicate only project owners can assign bugs, correct?

@bradfitz

This comment has been minimized.

Copy link
Member

commented Nov 30, 2017

We don't really use the Github Assignee feature much. Don't worry about it. Just declare that you're working on it with text as you did above.

@mrosier-qdt

This comment has been minimized.

Copy link
Contributor Author

commented Nov 30, 2017

SGTM. Thanks, Brad.

@gopherbot

This comment has been minimized.

Copy link

commented Dec 5, 2017

Change https://golang.org/cl/82055 mentions this issue: runtime: improve arm64 memclr implementation.

@gopherbot gopherbot closed this in b46d398 Mar 14, 2018

@golang golang locked and limited conversation to collaborators Mar 14, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.