Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
runtime: TestGcSys does not really pass, should be fixed or removed #23343
The runtime test
We should either discard the test or fix it so that it actually tests something about the GC.
(I noticed this because the test fails consistently using gccgo, which does not currently discard the slice allocation.)
I am curious if there is any general good practice to detect whether tests silently stopped doing what they should be doing. It is fairly easy for that to go under the radar if the test continues to pass or is always skipped.
I can imagine "write good tests" and using metrics like coverage, but when thousands of tests are involved (such as in the standard library), things can get out of hand.