cmd/link: silently performs incorrect relocations when linking foreign objects

[infinity0]

For example, when linking syso files.

Adding go:cgo_import_dynamic helps but (1) it was recently disabled for security reasons for non-cgo files, then reenabled because solaris needs it, so it's unclear if this policy will persist in the long-run for all architectures, and (2) you need to specify it for specific symbols rather than for all symbols. In any case, an error should be raised with a hint on what to do, rather than succeeding silently with invalid output.

The equivalent thing in Haskell Just Works with no extra annotations.

[andybons]

@ianlancetaylor

[ianlancetaylor]

Can you show us a self-contained example?

Does it work if you use -ldflags=-linkmode=external?

Perhaps we should default to external linking mode in the presence of any syso files.

[gopherbot]

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

[FiloSottile]

Reopening, I can provide a test case from FiloSottile/ed25519-dalek-rustgo#1.

[andybons]

Removing the WaitingForInfo tag worked around GopherBot fighting you :P.