New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/playground: in About text, document that vet is used #25462

Closed
meirf opened this Issue May 19, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@meirf
Member

meirf commented May 19, 2018

Now that vet is included in playground Run, the About text should mention it.

Current:

The service receives a Go program, compiles, links, and runs the program inside a sandbox, then returns the output.

Maybe something like "... receives a Go program, compiles, links, vets and runs the program inside a sandbox..."

@ysmolsky

One counterargument is that "go vet" is a pretty unique search query and goes straight to https://golang.org/cmd/vet anyway.

@gopherbot gopherbot added this to the Unreleased milestone May 19, 2018

@meirf meirf changed the title from x/playground: document that vet is used in About text to x/playground: in About text, document that vet is used May 19, 2018

@ysmolsky

This comment has been minimized.

Show comment
Hide comment
@ysmolsky

ysmolsky Oct 8, 2018

Member

I think we should do this. Preparing the patch.

Member

ysmolsky commented Oct 8, 2018

I think we should do this. Preparing the patch.

@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Oct 8, 2018

Change https://golang.org/cl/140497 mentions this issue: playground: mention vet in about text

gopherbot commented Oct 8, 2018

Change https://golang.org/cl/140497 mentions this issue: playground: mention vet in about text

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Oct 8, 2018

Member

I've deployed the new version. Thanks @ysmolsky!

Member

dmitshur commented Oct 8, 2018

I've deployed the new version. Thanks @ysmolsky!

matfax added a commit to gofunky/playground that referenced this issue Oct 9, 2018

playground: mention vet in about text
Fixes golang/go#25462

Change-Id: I11b861352b53f9492cd1f5c6d8c434edd68e4bd9
Reviewed-on: https://go-review.googlesource.com/c/140497
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment