Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/race: complete race detector on netbsd/amd64 #26403

Open
bradfitz opened this issue Jul 16, 2018 · 2 comments
Open

runtime/race: complete race detector on netbsd/amd64 #26403

bradfitz opened this issue Jul 16, 2018 · 2 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. help wanted NeedsFix The path to resolution is known, but the work has not been done. OS-NetBSD
Milestone
Unplanned

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Jul 16, 2018

The new netbsd/amd64 race detector support is not 100% done yet, per #19273 (comment)

We also don't have a builder for it.

This is a tracking bug to see it completed.

/cc @krytarowski
@bradfitz bradfitz added help wanted OS-NetBSD NeedsFix The path to resolution is known, but the work has not been done. labels Jul 16, 2018
@bradfitz bradfitz added this to the Unplanned milestone Jul 16, 2018
@krytarowski
Copy link
Contributor

krytarowski commented Jul 19, 2018

I will work on it after squashing the remaining failures in C/C++ style check-tsan:

$ check-tsan

********************
Testing Time: 1336.74s
********************
Failing Tests (8):
    ThreadSanitizer-x86_64 :: dtls.c
    ThreadSanitizer-x86_64 :: getline_nohang.cc
    ThreadSanitizer-x86_64 :: ignore_lib5.cc
    ThreadSanitizer-x86_64 :: ignored-interceptors-mmap.cc
    ThreadSanitizer-x86_64 :: mutex_lock_destroyed.cc
    ThreadSanitizer-x86_64 :: signal_block.cc
    ThreadSanitizer-x86_64 :: strerror_r.cc
    ThreadSanitizer-x86_64 :: vfork.cc

  Expected Passes    : 288
  Expected Failures  : 1
  Unsupported Tests  : 85
  Unexpected Failures: 8

Other than that, golang/race seems to use the StopTheWorld() operation that is unimplemented in the upstream version for now. (We have got an implementation in downstream GCC copy).

@gopherbot
Copy link

gopherbot commented Aug 27, 2018

Change https://golang.org/cl/131555 mentions this issue: cmd/dist: do not run race detector tests on netbsd

@bsiegert bsiegert mentioned this issue Aug 27, 2018
Closed
gopherbot pushed a commit that referenced this issue Aug 27, 2018
@bsiegert @bradfitz
cmd/dist: do not run race detector tests on netbsd
7334904 
The race detector is not fully functional on NetBSD yet. Without
this change, all.bash fails in TestOutput.

This unbreaks the netbsd-amd64 builder.

Update #26403
Fixes #27268

Change-Id: I2c7015692d3632aa1037f40155d4fc5c7bb1d8c3
Reviewed-on: https://go-review.googlesource.com/131555
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. help wanted NeedsFix The path to resolution is known, but the work has not been done. OS-NetBSD
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
3 participants
@bradfitz @krytarowski @gopherbot