Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/x509: doc: clarify package is aimed towards Web PKI support #26624

Open
adamdecaf opened this Issue Jul 26, 2018 · 3 comments

Comments

Projects
None yet
5 participants
@adamdecaf
Copy link
Contributor

adamdecaf commented Jul 26, 2018

It's been noted before that crypto/x509 is aimed towards only supporting the Web PKI. (See: #16858 (comment) and #24151 (comment)) However the documentation doesn't clearly state that.

This means it's a bit unclear what to expect from this package.

  • Is it valid for SystemCertPool() to return certificates for email signing?
  • How forgiving should parsing / validation be?
  • What level of extensibility (re: OID's) should be supported?

Explaining non-goals would also be helpful.

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Jul 26, 2018

Change https://golang.org/cl/126136 mentions this issue: crypto/x509: clarify package is for the web pki

@adamdecaf

This comment has been minimized.

Copy link
Contributor Author

adamdecaf commented Jul 26, 2018

@ianlancetaylor ianlancetaylor changed the title doc: crypto/x509: clarify package is aimed towards Web PKI support crypto/x509: doc: clarify package is aimed towards Web PKI support Aug 3, 2018

@ianlancetaylor ianlancetaylor added this to the Go1.12 milestone Aug 3, 2018

@odeke-em

This comment has been minimized.

Copy link
Member

odeke-em commented Jan 30, 2019

Kindly paging @FiloSottile, @agl commented on the CL, please take a look. Thank you.

@andybons andybons modified the milestones: Go1.12, Go1.13 Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.