New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: test fails for debug sections on Darwin #27502

Open
YoshikiShibata opened this Issue Sep 4, 2018 · 2 comments

Comments

Projects
None yet
5 participants
@YoshikiShibata

YoshikiShibata commented Sep 4, 2018

Please answer these questions before submitting your issue. Thanks!

What did you do?

Rebuild the lastest tip version with all.bash

What did you expect to see?

All tests pass.

What did you see instead?

##### ../misc/cgo/testso

##### ../misc/cgo/testsovar

##### ../misc/cgo/testcarchive
PASS

##### ../misc/cgo/testcshared
PASS

##### ../misc/cgo/testplugin
error opening DWARF: decoding dwarf section info at offset 0x0: too shortexit status 1
2018/09/05 07:43:23 Failed: exit status 1
2018/09/05 07:43:24 FAILED

Does this issue reproduce with the latest release (go1.11)?

N/A

System details

go version devel +b444215116 Tue Sep 4 20:41:58 2018 +0000 darwin/amd64
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/yoshiki.shibata/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/yoshiki.shibata/gocode"
GOPROXY=""
GORACE=""
GOROOT="/Users/yoshiki.shibata/tools/go"
GOTMPDIR=""
GOTOOLDIR="/Users/yoshiki.shibata/tools/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
GOROOT/bin/go version: go version devel +b444215116 Tue Sep 4 20:41:58 2018 +0000 darwin/amd64
GOROOT/bin/go tool compile -V: compile version devel +b444215116 Tue Sep 4 20:41:58 2018 +0000
uname -v: Darwin Kernel Version 17.7.0: Thu Jun 21 22:53:14 PDT 2018; root:xnu-4570.71.2~1/RELEASE_X86_64
ProductName:	Mac OS X
ProductVersion:	10.13.6
BuildVersion:	17G65
lldb --version: lldb-902.0.79.7
  Swift-4.1
@heschik

This comment has been minimized.

Contributor

heschik commented Sep 4, 2018

This was 9c83383. Sorry, I thought that the Mac trybots were enabled again so I didn't test it manually. I'm not in a position to do anything until tomorrow, maybe @aarzilli can take a look.

@gopherbot

This comment has been minimized.

gopherbot commented Sep 5, 2018

Change https://golang.org/cl/133435 mentions this issue: testplugin: disable DWARF tests on darwin

gopherbot pushed a commit that referenced this issue Sep 5, 2018

misc/cgo/testplugin: disable DWARF tests on darwin
For some reason on darwin the linker still can't add debug sections to
plugins. Executables importing "plugin" do have them, however.

Because of issue 25841, plugins on darwin would likely have bad debug
info anyway so, for now, this isn't a great loss.

This disables the check for debug sections in plugins for darwin only.

Updates #27502

Change-Id: Ib8f62dac1e485006b0c2b3ba04f86d733db5ee9a
Reviewed-on: https://go-review.googlesource.com/133435
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

@andybons andybons changed the title from misc/cgo/testplugin failed to misc/cgo/testplugin: fails for debug sections in plugins on Darwin Sep 5, 2018

@andybons andybons added the NeedsFix label Sep 5, 2018

@andybons andybons added this to the Go1.12 milestone Sep 5, 2018

@ianlancetaylor ianlancetaylor changed the title from misc/cgo/testplugin: fails for debug sections in plugins on Darwin to plugin: test fails for debug sections on Darwin Dec 13, 2018

@ianlancetaylor ianlancetaylor modified the milestones: Go1.12, Unplanned Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment