New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/importer: remove support for (now defunct) binary export format (reminder issue) #27999

Open
griesemer opened this Issue Oct 3, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@griesemer
Contributor

griesemer commented Oct 3, 2018

The compiler only generates the new indexed export format, and any support for the old binary export format has been removed.

We can eliminate the support from go/importer as well.

(Before we do, double-check that the latest version of that code is ported to x/tools where it needs to survive for another 3 release cycles - until 1.14.)

@griesemer griesemer added the NeedsFix label Oct 3, 2018

@griesemer griesemer added this to the Go1.12 milestone Oct 3, 2018

@griesemer griesemer self-assigned this Oct 3, 2018

@gopherbot

This comment has been minimized.

gopherbot commented Oct 17, 2018

Change https://golang.org/cl/143023 mentions this issue: go/importer: remove support for defunct binary export format

@gopherbot

This comment has been minimized.

gopherbot commented Oct 18, 2018

Change https://golang.org/cl/143024 mentions this issue: go/internal/gcimporter: rename file to better reflect new meaning

@alandonovan

This comment has been minimized.

Contributor

alandonovan commented Oct 19, 2018

We can't fix this bug until we've done #28260, otherwise there will be no export data format that go/types can both read and write.

@griesemer

This comment has been minimized.

Contributor

griesemer commented Dec 5, 2018

Moving to 1.13 - depends on #28260.

@griesemer griesemer modified the milestones: Go1.12, Go1.13 Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment