Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/importer: remove support for (now defunct) binary export format (reminder issue) #27999

Closed
griesemer opened this issue Oct 3, 2018 · 11 comments
Closed
Assignees
Milestone

Comments

@griesemer
Copy link
Contributor

@griesemer griesemer commented Oct 3, 2018

The compiler only generates the new indexed export format, and any support for the old binary export format has been removed.

We can eliminate the support from go/importer as well.

(Before we do, double-check that the latest version of that code is ported to x/tools where it needs to survive for another 3 release cycles - until 1.14.)

@griesemer griesemer added the NeedsFix label Oct 3, 2018
@griesemer griesemer added this to the Go1.12 milestone Oct 3, 2018
@griesemer griesemer self-assigned this Oct 3, 2018
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Oct 17, 2018

Change https://golang.org/cl/143023 mentions this issue: go/importer: remove support for defunct binary export format

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Oct 18, 2018

Change https://golang.org/cl/143024 mentions this issue: go/internal/gcimporter: rename file to better reflect new meaning

@alandonovan

This comment has been minimized.

Copy link
Contributor

@alandonovan alandonovan commented Oct 19, 2018

We can't fix this bug until we've done #28260, otherwise there will be no export data format that go/types can both read and write.

@griesemer

This comment has been minimized.

Copy link
Contributor Author

@griesemer griesemer commented Dec 5, 2018

Moving to 1.13 - depends on #28260.

@griesemer griesemer modified the milestones: Go1.12, Go1.13 Dec 5, 2018
@griesemer griesemer modified the milestones: Go1.13, Go1.14 May 6, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@griesemer

This comment has been minimized.

Copy link
Contributor Author

@griesemer griesemer commented Oct 22, 2019

#28260 has been fixed.

Verify that we don't need the binary export format anywhere before taking action on this.

cc: @stamblerre

@griesemer griesemer modified the milestones: Backlog, Go1.14 Oct 22, 2019
@griesemer

This comment has been minimized.

Copy link
Contributor Author

@griesemer griesemer commented Oct 22, 2019

Moving tentatively to 1.14.

@griesemer griesemer modified the milestones: Go1.14, Go1.15 Nov 12, 2019
@dmitshur

This comment has been minimized.

Copy link
Member

@dmitshur dmitshur commented Feb 19, 2020

This issue is currently labeled as early-in-cycle for Go 1.15. That time is now, so friendly ping. If it no longer needs to be done early in cycle, that label can be removed.

@gopherbot gopherbot closed this in c4c73ce Feb 19, 2020
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Feb 20, 2020

Change https://golang.org/cl/220237 mentions this issue: Revert "go/importer: remove support for defunct binary export format"

@bcmills bcmills reopened this Feb 20, 2020
@bcmills

This comment has been minimized.

Copy link
Member

@bcmills bcmills commented Feb 20, 2020

This broke current tests in x/tools, so it either needs to be reverted or those tests need to be updated or removed ASAP.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Feb 20, 2020

Change https://golang.org/cl/220277 mentions this issue: go/internal/gcimporter: update TestImportedTypes for BImportData removal

gopherbot pushed a commit to golang/tools that referenced this issue Feb 20, 2020
BImportData was removed from the standard library in CL 143023.
Update TestImportedTypes test data to use FindPkg instead.

Updates golang/go#27999.

Change-Id: I8ddb061da31187cc4a3b1c65f2d82d379a6c1066
Reviewed-on: https://go-review.googlesource.com/c/tools/+/220277
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@griesemer

This comment has been minimized.

Copy link
Contributor Author

@griesemer griesemer commented Feb 20, 2020

The x/tools breakage has been fixed. Closing again.

gopherbot pushed a commit that referenced this issue Feb 20, 2020
Also: Removed unused deref function.

Follow-up on https://golang.org/cl/143023.

Updates #27999.

Change-Id: I088265f0e3ce52029679407f0b84b734191d4d3c
Reviewed-on: https://go-review.googlesource.com/c/go/+/143024
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.