why this line don't need the defer?

[youfulife]

go/src/database/sql/sql.go

Line 2922 in 3bf9b77

rs.closemu.RUnlock()

[cznic]

Let me turn the question the other way around. Why that line should need a defer? I don't see any reason for that.

[zigo101]

@chenyoufu
This doesn't look like an issue.
It would be better to ask such questions on https://groups.google.com/forum/#!forum/golang-nuts or https://www.reddit.com/r/golang/

For your question, if you want to use defer, then the code should be written like this:

func (rs *Rows) Scan(dest ...interface{}) error {
	if err := func() error {
		rs.closemu.RLock()
		defer rs.closemu.RUnlock()

		if rs.lasterr != nil && rs.lasterr != io.EOF {
			return rs.lasterr
		}
		if rs.closed {
			return errors.New("sql: Rows are closed")
		}
		return nil
	}(); err != nil {
		return err
	}
	...

[agnivade]

Hi @chenyoufu

As already pointed above, this appears to be a question rather than a Go bug. We do not use the issue tracker for general discussions or questions like these. The Github bug tracker is only used for tracking bugs and proposals going through the Proposal Process.

For further questions, please have a look at Questions wiki page; it has a list of good places for asking questions.

Closing since this is not a bug.