cmd/go: Can't `go get github.com/augustoroman/v8`

[frederikcreemers]

What version of Go are you using (go version)?

$ go version
go version go1.11.1 darwin/amd64

Does this issue reproduce with the latest release?

I think I have the latest release

What operating system and processor architecture are you using (go env)?

macOS 10.13.4

What did you do?

$ go get -v github.com/augustoroman/v8
go: finding github.com/augustoroman/v8 latest
Fetching https://github.com?go-get=1
Parsing meta tags from https://github.com?go-get=1 (status code 200)
go get github.com/augustoroman/v8: no matching versions for query "latest"
Executed from a directory outside my $GOPATH containing `go.mod`

What did you expect to see?

I expected the v8 package to be downloaded and installed.

What did you see instead?

The output from the command above.

I originally posted about this in #27215, but was asked to create a separate issue, because this might be a problem where go sees the package name (v8) as a version indicator.

Environment:

GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/frederikcreemers/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/frederikcreemers/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/frederikcreemers/dev/marvin/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/q_/wgr019b53rx9b2lr3y7867bm0000gn/T/go-build238395171=/tmp/go-build -gno-record-gcc-switches -fno-common"

GO111MODULES is not set.

[frederikcreemers]

I've confirmed that the /v8 in the path is the problem. I've created a fork at github.com/bigblind/v-eight, and that works perfectly.

[andybons]

@bcmills @rsc

[hearot]

I've tried coding a script using the GitHub regex (see https://go.googlesource.com/go/+/go1.11.1/src/cmd/go/internal/get/vcs.go#983).

package main

import "regexp"
import "fmt"

func main() {
    var kregexp *regexp.Regexp
    reg := 
`^(?P<root>github\.com/[A-Za-z0-9_.\-]+/[A-Za-z0-9_.\-]+)(/[\p{L}0-9_.\-]+)*$`
    
    kregexp = regexp.MustCompile(reg)
    firstMatch, secondMatch := kregexp.FindStringSubmatch("github.com/hearot/ArgoScuolaNext-Go"), 
kregexp.FindStringSubmatch("github.com/augustoroman/v8")

    firstMatchMap := map[string]string{}
    secondMatchMap := map[string]string{}

    for i, name := range kregexp.SubexpNames() {
        if name != "" && firstMatchMap[name] == "" {
            firstMatchMap[name] = firstMatch[i]
        }
    }

    for i, name := range kregexp.SubexpNames() {
        if name != "" && secondMatchMap[name] == "" {
            secondMatchMap[name] = secondMatch[i]
        }
    }

    fmt.Printf("First match: %s", firstMatchMap)
    fmt.Println()
    fmt.Printf("Second match: %s", secondMatchMap)
}

And I got this:

First match: map[root:github.com/hearot/ArgoScuolaNext-Go]
Second match: map[root:github.com/augustoroman/v8]

That regex works perfectly, there are no errors. So, I've also tried to do the go get -v github.com/augustoroman/v8 command and I've got no errors, everything has been installed successfully.

[agnivade]

/cc @myitcv

[myitcv]

Last time I saw comment on this, @rsc's thoughts were that such a case is extremely rare, and hence renaming the package is the solution (per @bigblind):

https://go-review.googlesource.com/c/vgo/+/122399/5/vendor/cmd/go/internal/modfetch/coderepo.go#307

[rsc]

Yes, sorry. My suggestion is v8js.

[mattmoor]

This is not extremely rare. This will effect like half of the K8s libraries.