net/http/httputil: NewSingleHostReverseProxy doesn't preserve query parameters

[gopherbot]

by RyanneDolan:

What steps will reproduce the problem?
1. use NewSingleHostReverseProxy to create reverse proxy server
2. send HTTP request with path?query
3. base/path is preserved, but not ?query

What is the expected output?

proxy'd request should include query parameters of original request

What do you see instead?

query params removed

Which revision are you using?  (hg identify)
1107a7d3cb07 weekly/weekly.2012-01-27

The weekly and tip show:

req.URL.Scheme = target.Scheme
req.URL.Host = target.Host
req.URL.Path = singleJoiningSlash(target.Path, req.URL.Path)
req.URL.RawQuery = target.RawQuery

What is the last line there supposed to do?  Deleting it restores expected behavior.

[bradfitz]

Comment 1:

I think this used to work but got broken with the recent URL changes?
Will fix.

Labels changed: added priority-go1, removed priority-triage.

Owner changed to @bradfitz.

Status changed to Accepted.

[gopherbot]

Comment 2 by RyanneDolan:

Yeah, it used to work.  I think it was "fixed" incorrectly with the URL changes.  It
looks like a simple matter of deleting that last line above, since req.URL.RawQuery
should not change.

[bradfitz]

Comment 4:

http://golang.org/cl/5642056

Status changed to Started.

[bradfitz]

Comment 5:

This issue was closed by revision 518ee11.

Status changed to Fixed.