Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: TestRemoveAllDot failing on Plan 9 #28903

Closed
0intro opened this issue Nov 21, 2018 · 5 comments
Closed

os: TestRemoveAllDot failing on Plan 9 #28903

0intro opened this issue Nov 21, 2018 · 5 comments
Assignees
Milestone

Comments

@0intro
Copy link
Member

@0intro 0intro commented Nov 21, 2018

CL 150497 enabled TestRemoveAllDot on "noat" (see removeall_noat.go) systems (including Plan 9).

This test is failing on Plan 9.

--- FAIL: TestRemoveAllDot (0.00s)
    removeall_test.go:235: RemoveAll succeed to remove .
FAIL
FAIL	os	2.055s

See https://build.golang.org/log/62555ab829ee330629c6189fef3507411e657a55

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 21, 2018

Change https://golang.org/cl/150717 mentions this issue: os: skip TestRemoveAllDot on plan9

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 21, 2018

Change https://golang.org/cl/150621 mentions this issue: os: prevent RemoveAll to remove "." on Plan 9

@mattn

This comment has been minimized.

Copy link
Member

@mattn mattn commented Nov 21, 2018

Sorry, OT. Seems that the link /c/150621 does not point to go-review.

@0intro

This comment has been minimized.

Copy link
Member Author

@0intro 0intro commented Nov 21, 2018

I think there is some kind of issue with the golang.org redirect. The direct link works: https://go-review.googlesource.com/c/go/+/150621

@0intro 0intro self-assigned this Nov 21, 2018
@0intro 0intro added the OS-Plan9 label Nov 21, 2018
@0intro 0intro added this to the Go1.12 milestone Nov 21, 2018
@agnivade

This comment has been minimized.

Copy link
Contributor

@agnivade agnivade commented Nov 21, 2018

redirect issue - #28836

@gopherbot gopherbot closed this in 47df645 Nov 21, 2018
@golang golang locked and limited conversation to collaborators Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.