Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: TestRemoveAllDot failing on Plan 9 #28903

Closed
0intro opened this issue Nov 21, 2018 · 5 comments
Closed

os: TestRemoveAllDot failing on Plan 9 #28903

0intro opened this issue Nov 21, 2018 · 5 comments
Labels
FrozenDueToAge OS-Plan9
Milestone
Go1.12

Comments

@0intro
Copy link
Member

0intro commented Nov 21, 2018

CL 150497 enabled TestRemoveAllDot on "noat" (see removeall_noat.go) systems (including Plan 9).

This test is failing on Plan 9.

--- FAIL: TestRemoveAllDot (0.00s)
    removeall_test.go:235: RemoveAll succeed to remove .
FAIL
FAIL	os	2.055s

See https://build.golang.org/log/62555ab829ee330629c6189fef3507411e657a55
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/150717 mentions this issue: os: skip TestRemoveAllDot on plan9

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/150621 mentions this issue: os: prevent RemoveAll to remove "." on Plan 9

@mattn
Copy link
Member

mattn commented Nov 21, 2018

Sorry, OT. Seems that the link /c/150621 does not point to go-review.

@0intro
Copy link
Member Author

0intro commented Nov 21, 2018

I think there is some kind of issue with the golang.org redirect. The direct link works: https://go-review.googlesource.com/c/go/+/150621

@0intro 0intro self-assigned this Nov 21, 2018
@0intro 0intro added this to the Go1.12 milestone Nov 21, 2018
@agnivade
Copy link
Contributor

redirect issue - #28836

@golang golang locked and limited conversation to collaborators Nov 21, 2019
@rsc rsc unassigned 0intro Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-Plan9
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
4 participants
@mattn @agnivade @0intro @gopherbot