Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/doc: collect methods from embedded interfaces #2971

Open
griesemer opened this issue Feb 9, 2012 · 14 comments
Open

go/doc: collect methods from embedded interfaces #2971

griesemer opened this issue Feb 9, 2012 · 14 comments
Assignees
Milestone

Comments

@griesemer
Copy link
Contributor

@griesemer griesemer commented Feb 9, 2012

Summary says it all.
@rsc
Copy link
Contributor

@rsc rsc commented Feb 10, 2012

Comment 2:

Is this about interface fields embedded in structs
or interface types embedded in interface type definitions?
In both cases, this is only interesting for embedded
unexported interface types that contain exported methods.
If there is an error embedded in a struct, that should
be hidden (it's an unexported field) but the struct type
should show an Error() string method.  If there is an
error embedded in an interface, that should be shown
as 'error' in the interface definition (and is a separate issue #).
Russ
@rsc
Copy link
Contributor

@rsc rsc commented Feb 14, 2012

Comment 3:

Now that error is fixed, I am assuming this is about
type T interface {
     x
}
type x interface {
     M()
}
turning into (in the display)
type T interface {
    M()
}
This doesn't come up in the Go source tree, so I think need not hold up Go 1.

Labels changed: added priority-later, removed priority-triage.

@rsc
Copy link
Contributor

@rsc rsc commented Sep 12, 2012

Comment 4:

Labels changed: added go1.1maybe.

@rsc
Copy link
Contributor

@rsc rsc commented Dec 9, 2012

Comment 6:

Labels changed: removed go1.1maybe.

@rsc
Copy link
Contributor

@rsc rsc commented Mar 12, 2013

Comment 7:

[The time for maybe has passed.]
@rsc
Copy link
Contributor

@rsc rsc commented Jul 30, 2013

Comment 8:

Labels changed: added go1.2maybe.

@rsc
Copy link
Contributor

@rsc rsc commented Jul 30, 2013

Comment 9:

Labels changed: added feature.

@robpike
Copy link
Contributor

@robpike robpike commented Aug 16, 2013

Comment 10:

Labels changed: added go1.3maybe, removed go1.2maybe.

@robpike
Copy link
Contributor

@robpike robpike commented Aug 20, 2013

Comment 11:

Labels changed: removed go1.3maybe.

@rsc
Copy link
Contributor

@rsc rsc commented Nov 27, 2013

Comment 12:

Labels changed: added go1.3maybe.

@rsc
Copy link
Contributor

@rsc rsc commented Nov 27, 2013

Comment 13:

Labels changed: removed feature.

@rsc
Copy link
Contributor

@rsc rsc commented Dec 4, 2013

Comment 14:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor

@rsc rsc commented Dec 4, 2013

Comment 15:

Labels changed: added repo-main.

@griesemer
Copy link
Contributor Author

@griesemer griesemer commented Jul 7, 2016

Copied from #16043 (closed), comment by @jimmyfrasche: related #6600 #10593 #7823 (more related issues, some fixed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.