os: Getenverror -> GetenvError ?

[bradfitz]

Rename Getenverror to GetenvError?

Error is capitalized in NewSyscallError, and getenverror isn't a libc function like
getenv is.

[dsymonds]

Comment 1:

Is it a useful enough function to keep? It looks like the only time you'd notice the
difference between GetenvError and Getenv is if you pass an empty key, or if you want to
distinguish an unset environment variable from an empty-but-set one. The former case is
trivially checkable from callers; the latter case can either use syscall.Getenv
directly, or use os.Environ and parse/iterate themselves.
Just my 2¢.

Labels changed: added priority-go1, removed priority-triage.

[rsc]

Comment 2:

Let's delete Getenverror.  People who need to distinguish those
two cases (as package time does) know can use syscall.Getenv.

[bradfitz]

Comment 3:

This issue was closed by revision efacb2a.

Status changed to Fixed.