math: remove assembly stubs #31362
Open
math: remove assembly stubs #31362
Labels
Milestone
Comments
Change https://golang.org/cl/173398 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Apr 23, 2019
Where assembly functions are just jumps to the Go implementation put them into a stubs_<arch>.s file. This reduces the number of files considerably and makes it easier to see what is really implemented in assembly. I've also run the stubs files through asmfmt to format them in a more consistent way. Eventually we should replace these 'stub' assembly files with a pure Go implementation now that we have mid-stack inlining (see #31362). Change-Id: If5b2022dcc23e1299f1b7ba79884f1b1263d0f7f Reviewed-on: https://go-review.googlesource.com/c/go/+/173398 Run-TryBot: Michael Munday <mike.munday@ibm.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I could be wrong, but I think now that we have mid-stack inlining it should be possible to move the math package from this pattern:
To something more like this pattern:
This would have the side benefit of allowing architectures that use the generic implementation to inline it if it is cheap enough. It might also make stdlib easier to build with other compilers (#31330).
The text was updated successfully, but these errors were encountered: