x/tools/gopls: bad completion insertion after syntax error

[muirdm]

In this code

package foo

func foo() {
	foo(a ...interface{})
	f<>
}

Completing "f" to "foo" ends up inserting "ffoo" instead of "foo". This is because the syntax error on the previous line completely obscures the "f" *ast.Ident, so we don't detect it properly as the prefix. Perhaps if we are in a BadExpr we could "manually" detect the surrounding identifier so completion still works to some degree?

/cc @stamblerre

[gopherbot]

Change https://golang.org/cl/195039 mentions this issue: internal/lsp: fix completion prefix detection with syntax errors

[seh]

What's weird is that it seems that this problem only arises the first time selecting a given completion. If I delete some text, then type enough again to summon the same completion, if I select one I've selected before, I don't get the extra text inserted.

I described this problem in the "emacs" channel in the "Gophers" Slack workspace.