Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: rename doesn't work for all occurences #32877

Open
inliquid opened this issue Jul 1, 2019 · 2 comments

Comments

Projects
None yet
4 participants
@inliquid
Copy link

commented Jul 1, 2019

VS Code. Latest gopls code from master. Trying quite simple rename operation:
изображение

@gopherbot gopherbot added this to the Unreleased milestone Jul 1, 2019

@gopherbot gopherbot added the gopls label Jul 1, 2019

@stamblerre

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

Right now, rename only works within a package and its tests. We are still working on a strategy for renaming packages in a module.

/cc @suzmue

@suzmue

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

This is closely tied to issue #32869

Once find all references in the module level is supported, we should be able to global renaming.

@stamblerre stamblerre changed the title x/tools/cmd/gopls: rename doesn't work for all occurences x/tools/gopls: rename doesn't work for all occurences Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.