Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: missing section for relocation target [1.12 backport] #33040

Closed
gopherbot opened this issue Jul 10, 2019 · 3 comments

Comments

Assignees
No one assigned
Labels
CherryPickCandidate
Projects
None yet
Milestone
  Go1.12.8
1 participant
@gopherbot
@gopherbot
Copy link

commented Jul 10, 2019

@ianlancetaylor requested issue #30768 to be considered for backport to the next 1.12 minor release.

@gopherbot please open backport to 1.12

@gopherbot gopherbot added the CherryPickCandidate label Jul 10, 2019

@gopherbot gopherbot referenced this issue Jul 10, 2019

Closed

cmd/link: missing section for relocation target #30768

@gopherbot gopherbot added this to the Go1.12.8 milestone Jul 10, 2019

@gopherbot

This comment has been minimized.

Sign in to view
Copy link
Author

commented Jul 15, 2019

Change https://golang.org/cl/186183 mentions this issue: [release-branch.go1.12] cmd/link: put shlib ".type" functions in internal ABI
@gopherbot

This comment has been minimized.

Sign in to view
Copy link
Author

commented Jul 15, 2019

Change https://golang.org/cl/186278 mentions this issue: [release-branch.go1.12] cmd/link: put shlib ".type" functions in internal ABI
@gopherbot

This comment has been minimized.

Sign in to view
Copy link
Author

commented Jul 16, 2019

Closed by merging f194c9f to release-branch.go1.12.

@gopherbot gopherbot closed this Jul 16, 2019

gopherbot pushed a commit that referenced this issue Jul 16, 2019

@ianlancetaylor
[release-branch.go1.12] cmd/link: put shlib ".type" functions in inte… 
…rnal ABI

These functions are compiler generated, and as such are only available
in the internal ABI. Doing this avoids generating an alias symbol.
Doing that avoids confusion between unmangled and mangled type symbols.

Updates #30768
Fixes #33040

Change-Id: I8aba3934ffa994b1a19fc442cfe3e05642792a25
Reviewed-on: https://go-review.googlesource.com/c/go/+/186278
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
f194c9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.